From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ImXTF-0004zJ-A7
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 12:28:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ImXTC-0004vH-F7
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 12:28:08 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ImXTB-0004uu-Js
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 12:28:05 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1ImWSO-0000vK-2y
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 11:23:12 -0400
Date: Mon, 29 Oct 2007 15:23:09 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is
	connected the cdrom
Message-ID: <20071029152309.GF18384@networkno.de>
References: <11936114152690-git-send-email-Laurent.Vivier@bull.net>
	<11936114153499-git-send-email-Laurent.Vivier@bull.net>
	<20071029132525.GA7128@redhat.com>
	<fb249edb0710290749n5995d6a9j98f2b9d2ffc7d8d9@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fb249edb0710290749n5995d6a9j98f2b9d2ffc7d8d9@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: qemu-devel@nongnu.org

andrzej zaborowski wrote:
> On 29/10/2007, Daniel P. Berrange <berrange@redhat.com> wrote:
> > On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrote:
> > > From: Laurent Vivier <vivierl@frecb07144.(none)>
> > >
> > > This patch allows to define where is connected the CDROM device (bus,
> > > unit).
> > > It extends the "-cdrom" syntax to add these paramaters:
> > >
> > >      -cdrom file[,if=type][,bus=n][,unit=m]
> > >
> > >  where "type" defines the interface (by default, "ide")
> > >        "n" defines the bus number (by default 1)
> > >        "m" defines the unit number (by default 0)
> >
> >
> > Having a separately named arg just for CDROMs was always rather odd/unhelpful.
> > I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc unchanged
> > and use the -disk for setting up all types of disks, floppys, cdroms, etc. It
> > would just require one extra field for the -disk arg:
> 
> Sounds logical and I thought this was the plan. I also wouldn't mind
> having -sda, -sdb... following the intuitive naming based on linux
> /dev, but IIRC there were some people on the list who didn't like this
> idea. (I know /dev/sda doesn't have to be an SCSI disk on some recent
> systems, but it's still the most intuitive name for most users).

But it won't hold in future, and on non-Linux systems. A -disk parameter
with backward compatibility aliases sounds good to me.


Thiemo