From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImWh1-00078H-0l for qemu-devel@nongnu.org; Mon, 29 Oct 2007 11:38:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImWh0-00077h-56 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 11:38:18 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImWgz-00077Q-Pv for qemu-devel@nongnu.org; Mon, 29 Oct 2007 11:38:17 -0400 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImWXP-0003G5-O0 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 11:28:24 -0400 Date: Mon, 29 Oct 2007 15:28:20 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom Message-ID: <20071029152820.GF7128@redhat.com> References: <11936114152690-git-send-email-Laurent.Vivier@bull.net> <11936114153499-git-send-email-Laurent.Vivier@bull.net> <20071029132525.GA7128@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: andrzej zaborowski Cc: qemu-devel@nongnu.org On Mon, Oct 29, 2007 at 03:49:18PM +0100, andrzej zaborowski wrote: > On 29/10/2007, Daniel P. Berrange wrote: > > On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrote: > > > From: Laurent Vivier > > > > > > This patch allows to define where is connected the CDROM device (bus, > > > unit). > > > It extends the "-cdrom" syntax to add these paramaters: > > > > > > -cdrom file[,if=type][,bus=n][,unit=m] > > > > > > where "type" defines the interface (by default, "ide") > > > "n" defines the bus number (by default 1) > > > "m" defines the unit number (by default 0) > > > > > > Having a separately named arg just for CDROMs was always rather odd/unhelpful. > > I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc unchanged > > and use the -disk for setting up all types of disks, floppys, cdroms, etc. It > > would just require one extra field for the -disk arg: > > Sounds logical and I thought this was the plan. I also wouldn't mind > having -sda, -sdb... following the intuitive naming based on linux > /dev, but IIRC there were some people on the list who didn't like this > idea. (I know /dev/sda doesn't have to be an SCSI disk on some recent > systems, but it's still the most intuitive name for most users). Adding more -sda arguments is just asking for trouble. On recent Fedora, even IDE disks will end up as /dev/sdNNN named devices. So what happens when you have -hda & -sda at same time.... pain & suffering is what happens :-) Avoiding device names as args by just using -disk is nicer Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|