From: Thiemo Seufer <ths@networkno.de>
To: Thayne Harbaugh <thayne@c2.net>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] strace rework
Date: Thu, 1 Nov 2007 00:09:44 +0000 [thread overview]
Message-ID: <20071101000944.GM7712@networkno.de> (raw)
In-Reply-To: <1193842829.19343.24.camel@phantasm.home.enterpriseandprosperity.com>
Thayne Harbaugh wrote:
>
> On Sat, 2007-10-27 at 14:26 +0100, Thiemo Seufer wrote:
> > Thayne Harbaugh wrote:
> > > This is a rework of Stuart Anderson's strace patch. I've fixed
> > > target-to-host and host-to-target syscall lookups so that the proper
> > > host or target errno is returned.
> >
> > It didn't build for me due to the a missing target_to_host_errno
> > function.
>
> This isn't obvious to me. It also doesn't appear that you included this
> error in the output you sent.
>
> > Could you also have a look at the compiler warnings
> > from strace.c? I see e.g.:
>
> <miles of warnings deleted>
>
> Thank you for sending me the warnings. I've reworked it so that
> function arguments are passed correctly, target addresses have access
> checked and locked and that proper print format codes are used.
>
> Attached is the new version. Please send me feedback.
Comitted. Could you also cook up a patch which documents the feature?
Thiemo
next prev parent reply other threads:[~2007-11-01 0:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 14:24 [Qemu-devel] [PATCH] strace rework Thayne Harbaugh
2007-10-27 13:26 ` Thiemo Seufer
2007-10-31 15:00 ` Thayne Harbaugh
2007-11-01 0:09 ` Thiemo Seufer [this message]
2007-11-01 0:08 ` Thayne Harbaugh
2007-11-01 1:01 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101000944.GM7712@networkno.de \
--to=ths@networkno.de \
--cc=qemu-devel@nongnu.org \
--cc=thayne@c2.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).