From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1InORJ-0004NZ-6I
	for qemu-devel@nongnu.org; Wed, 31 Oct 2007 21:01:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1InORG-0004NM-Vf
	for qemu-devel@nongnu.org; Wed, 31 Oct 2007 21:01:39 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1InORG-0004NI-Mc
	for qemu-devel@nongnu.org; Wed, 31 Oct 2007 21:01:38 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1InORG-0003zW-8x
	for qemu-devel@nongnu.org; Wed, 31 Oct 2007 21:01:38 -0400
Date: Thu, 1 Nov 2007 01:01:14 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [PATCH] strace rework
Message-ID: <20071101010114.GN7712@networkno.de>
References: <1193063060.5068.45.camel@phantasm.home.enterpriseandprosperity.com>
	<20071027132612.GK29176@networkno.de>
	<1193842829.19343.24.camel@phantasm.home.enterpriseandprosperity.com>
	<20071101000944.GM7712@networkno.de>
	<1193875721.19343.63.camel@phantasm.home.enterpriseandprosperity.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1193875721.19343.63.camel@phantasm.home.enterpriseandprosperity.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thayne Harbaugh <thayne@c2.net>
Cc: qemu-devel <qemu-devel@nongnu.org>

Thayne Harbaugh wrote:
> 
> On Thu, 2007-11-01 at 00:09 +0000, Thiemo Seufer wrote:
> > Thayne Harbaugh wrote:
> > > 
> > > On Sat, 2007-10-27 at 14:26 +0100, Thiemo Seufer wrote:
> > > > Thayne Harbaugh wrote:
> > > > > This is a rework of Stuart Anderson's strace patch.  I've fixed
> > > > > target-to-host and host-to-target syscall lookups so that the proper
> > > > > host or target errno is returned.
> > > > 
> > > > It didn't build for me due to the a missing target_to_host_errno
> > > > function.
> > > 
> > > This isn't obvious to me.  It also doesn't appear that you included this
> > > error in the output you sent.
> > > 
> > > >  Could you also have a look at the compiler warnings
> > > > from strace.c? I see e.g.:
> > > 
> > > <miles of warnings deleted>
> > > 
> > > Thank you for sending me the warnings.  I've reworked it so that
> > > function arguments are passed correctly, target addresses have access
> > > checked and locked and that proper print format codes are used.
> > > 
> > > Attached is the new version.  Please send me feedback.
> > 
> > Comitted. Could you also cook up a patch which documents the feature?
> 
> Awesome!  Thank you.
> 
> Yes, I'll be writing piles of documentation from user docs to
> development code guides.  Is there a directory that we can dump things
> into?

Not yet, but you can send a patch which creates a doc subdirectory. :-)


Thiemo