From: Thiemo Seufer <ths@networkno.de>
To: uli@suse.de
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] S/390 Host support status
Date: Mon, 5 Nov 2007 14:02:10 +0000 [thread overview]
Message-ID: <20071105140210.GA15181@networkno.de> (raw)
This is the remaining bit of s390 host support code from your earlier
patch. Could you check if this bit is still needed?
Also, if it does something useful, I suspect that it is incomplete.
gen_setcc duplicates the same logic, wouldn't it need to stay in sync?
Thiemo
--- qemu/target-i386/translate.c 2007-06-26 08:35:18.000000000 +0000
+++ qemu-s390/target-i386/translate.c 2007-07-30 13:57:39.000000000 +0000
@@ -1795,7 +1795,11 @@
case CC_OP_SUBW:
case CC_OP_SUBL:
case CC_OP_SUBQ:
+#ifdef __s390__
+ func = NULL; /* does not work on S/390 for unknown reasons */
+#else
func = gen_jcc_sub[s->cc_op - CC_OP_SUBB][jcc_op];
+#endif
break;
/* some jumps are easy to compute */
@@ -1843,7 +1847,11 @@
func = gen_jcc_sub[(s->cc_op - CC_OP_ADDB) % 4][jcc_op];
break;
case JCC_S:
+#ifdef __s390__
+ func = NULL;
+#else
func = gen_jcc_sub[(s->cc_op - CC_OP_ADDB) % 4][jcc_op];
+#endif
break;
default:
func = NULL;
reply other threads:[~2007-11-05 14:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105140210.GA15181@networkno.de \
--to=ths@networkno.de \
--cc=qemu-devel@nongnu.org \
--cc=uli@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).