From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ip2Wu-0000Nx-ET for qemu-devel@nongnu.org; Mon, 05 Nov 2007 09:02:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ip2Wt-0000Nl-F4 for qemu-devel@nongnu.org; Mon, 05 Nov 2007 09:02:15 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ip2Wt-0000Ni-Bg for qemu-devel@nongnu.org; Mon, 05 Nov 2007 09:02:15 -0500 Received: from relay01.mx.bawue.net ([193.7.176.67]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ip2Ws-0006IY-PR for qemu-devel@nongnu.org; Mon, 05 Nov 2007 09:02:14 -0500 Date: Mon, 5 Nov 2007 14:02:10 +0000 From: Thiemo Seufer Message-ID: <20071105140210.GA15181@networkno.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] S/390 Host support status Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: uli@suse.de Cc: qemu-devel@nongnu.org This is the remaining bit of s390 host support code from your earlier patch. Could you check if this bit is still needed? Also, if it does something useful, I suspect that it is incomplete. gen_setcc duplicates the same logic, wouldn't it need to stay in sync? Thiemo --- qemu/target-i386/translate.c 2007-06-26 08:35:18.000000000 +0000 +++ qemu-s390/target-i386/translate.c 2007-07-30 13:57:39.000000000 +0000 @@ -1795,7 +1795,11 @@ case CC_OP_SUBW: case CC_OP_SUBL: case CC_OP_SUBQ: +#ifdef __s390__ + func = NULL; /* does not work on S/390 for unknown reasons */ +#else func = gen_jcc_sub[s->cc_op - CC_OP_SUBB][jcc_op]; +#endif break; /* some jumps are easy to compute */ @@ -1843,7 +1847,11 @@ func = gen_jcc_sub[(s->cc_op - CC_OP_ADDB) % 4][jcc_op]; break; case JCC_S: +#ifdef __s390__ + func = NULL; +#else func = gen_jcc_sub[(s->cc_op - CC_OP_ADDB) % 4][jcc_op]; +#endif break; default: func = NULL;