From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Iq0g5-0007Mq-Ep
	for qemu-devel@nongnu.org; Thu, 08 Nov 2007 01:15:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Iq0g3-0007La-OR
	for qemu-devel@nongnu.org; Thu, 08 Nov 2007 01:15:44 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Iq0g3-0007LX-Ix
	for qemu-devel@nongnu.org; Thu, 08 Nov 2007 01:15:43 -0500
Received: from mx20.gnu.org ([199.232.41.8])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <amit.shah@qumranet.com>)
	id 1Iq0g3-0005Qi-HV
	for qemu-devel@nongnu.org; Thu, 08 Nov 2007 01:15:43 -0500
Received: from mis011-2.exch011.intermedia.net ([64.78.21.129])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@qumranet.com>) id 1Iq0fx-0001dU-Ny
	for qemu-devel@nongnu.org; Thu, 08 Nov 2007 01:15:39 -0500
From: Amit Shah <amit.shah@qumranet.com>
Date: Thu, 8 Nov 2007 11:42:56 +0530
References: <cc1a3d4ee5e648e13b3c75fc62d9c6c00405c322.1194464687.git.amit.shah@qumranet.com>
	<1194465692.32757.2.camel@basalt>
In-Reply-To: <1194465692.32757.2.camel@basalt>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200711081142.56746.amit.shah@qumranet.com>
Subject: [Qemu-devel] Re: [kvm-devel] [PATCH 1/2] KVM userspace: Add PCI
	device passthrough support
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org

On Thursday 08 November 2007 01:31:32 Hollis Blanchard wrote:
> I'm sorry these comments aren't substantive, but please watch your
> whitespace...

Hi Hollis,

Thanks for going through this. We know about these issues; the userspace is 
kind of messy since it's collected from various sources and we are urging the 
people who have done this to provide good patches.

These aren't ready yet for inclusion, we've sent them out to get comments on 
the overall solution for PCI passthrough.

> On Wed, 2007-11-07 at 21:45 +0200, Amit Shah wrote:
> > diff --git a/qemu/Makefile b/qemu/Makefile
> > index 053c88c..3e599f3 100644
> > --- a/qemu/Makefile
> > +++ b/qemu/Makefile
> > @@ -37,7 +37,7 @@ qemu-img$(EXESUF): qemu-img.c cutils.c block.c
> > block-raw.c block-cow.c block-qco
> >  dyngen$(EXESUF): dyngen.c
> >         $(HOST_CC) $(CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -o $@ $^
> >
> > -clean:
> > +clean:
> >  # avoid old build problems by removing potentially incorrect old
> > files
> >         rm -f config.mak config.h op-i386.h opc-i386.h gen-op-i386.h
> > op-arm.h opc-arm.h gen-op-arm.h
> >         rm -f *.o *.a $(TOOLS) dyngen$(EXESUF) TAGS cscope.* *.pod *~
> > */*~
>
> Extra space.
>
> > @@ -88,8 +88,8 @@ endif
> >  test speed test2: all
> >         $(MAKE) -C tests $@
> >
> > -TAGS:
> > -       etags *.[ch] tests/*.[ch]
> > +TAGS:
> > +       etags *.[ch] tests/*.[ch] hw/passthrough/*.[ch]
> >
> >  cscope:
> >         rm -f ./cscope.*
>
> Another extra space.
>
> > diff --git a/qemu/exec.c b/qemu/exec.c
> > index 3e588d5..7a21ca5 100644
> > --- a/qemu/exec.c
> > +++ b/qemu/exec.c
> > @@ -2484,6 +2484,7 @@ int cpu_register_io_memory(int io_index,
> >          if (io_mem_nb >= IO_MEM_NB_ENTRIES)
> >              return -1;
> >          io_index = io_mem_nb++;
> > +       fprintf(stderr, "iomem index %d out of %d\n", io_index,
> > IO_MEM_NB_ENTRIES);
> >      } else {
> >          if (io_index >= IO_MEM_NB_ENTRIES)
> >              return -1;
>
> Bad indentation.
>
> I didn't check the rest of your patches for this, so you should skim
> them...