From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IqZgu-0003VT-7x
	for qemu-devel@nongnu.org; Fri, 09 Nov 2007 14:38:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IqZgo-0003T6-VP
	for qemu-devel@nongnu.org; Fri, 09 Nov 2007 14:38:55 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IqZgn-0003Sk-IZ
	for qemu-devel@nongnu.org; Fri, 09 Nov 2007 14:38:49 -0500
Received: from tapir.sajinet.com.pe ([66.139.79.212])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <carenas@sajinet.com.pe>) id 1IqZgn-000647-8k
	for qemu-devel@nongnu.org; Fri, 09 Nov 2007 14:38:49 -0500
Date: Fri, 9 Nov 2007 13:43:19 -0600
From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
Message-ID: <20071109194319.GA7518@tapir>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: [Qemu-devel] [RESEND] [PATCH] show usage and abort if unknown
	option is passed to configure
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Any comments on this?, is ignoring unknown parameters to configure a feature
as I suspect to prevent build failures on users that assume that it is
autoconf based and try to enforce the defaults with an unknown option like
--enable-sdl?

Carlo

----- Forwarded message from Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe> -----

Date: Mon, 22 Oct 2007 20:31:35 -0500
From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
To: qemu-devel@nongnu.org
Subject: [PATCH] show usage and abort if unknown option is passed to configure
User-Agent: Mutt/1.4.1i

The following patch prints an error if an unknown option is passed to
configure and directs the script to show usage information.

Carlo

---
Index: configure
===================================================================
RCS file: /sources/qemu/qemu/configure,v
retrieving revision 1.165
diff -u -r1.165 configure
--- configure	18 Oct 2007 20:51:48 -0000	1.165
+++ configure	23 Oct 2007 01:23:58 -0000
@@ -306,6 +303,8 @@
         *)     echo "undefined SPARC architecture. Exiting";exit 1;;
       esac
   ;;
+  *) echo "ERROR: unknown option $opt"; show_help="yes"
+  ;;
   esac
 done
 

----- End forwarded message -----