From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IrCwp-0004GK-LE
	for qemu-devel@nongnu.org; Sun, 11 Nov 2007 08:33:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IrCwn-0004FV-SV
	for qemu-devel@nongnu.org; Sun, 11 Nov 2007 08:33:58 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IrCwn-0004FQ-J0
	for qemu-devel@nongnu.org; Sun, 11 Nov 2007 08:33:57 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1IrCwn-0006KT-1z
	for qemu-devel@nongnu.org; Sun, 11 Nov 2007 08:33:57 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH/RFC] overflow and register size mismatch in
	sh4-softmmu
Date: Sun, 11 Nov 2007 13:33:41 +0000
References: <20071111131113.GC25322@tapir>
In-Reply-To: <20071111131113.GC25322@tapir>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200711111333.42628.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sunday 11 November 2007, Carlo Marcelo Arenas Belon wrote:
> as shown by the following warning when compiling HEAD :
>
>   qemu/target-sh4/translate.c: In function `cpu_sh4_reset':
>   qemu/target-sh4/translate.c:139: warning: overflow in implicit constant
> conversion
>...
> the following patch changes the logic to use a helper function
> -    env->fp_status.float_rounding_mode = float_round_to_zero;
> +    set_float_rounding_mode(float_round_to_zero, &env->fp_status);

This is just hiding the bug.

Paul