From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IrH5Q-0006gF-04 for qemu-devel@nongnu.org; Sun, 11 Nov 2007 12:59:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IrH5P-0006fX-Ax for qemu-devel@nongnu.org; Sun, 11 Nov 2007 12:59:07 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrH5P-0006fO-3h for qemu-devel@nongnu.org; Sun, 11 Nov 2007 12:59:07 -0500 Received: from tapir.sajinet.com.pe ([66.139.79.212]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IrH5O-0002Ma-Fj for qemu-devel@nongnu.org; Sun, 11 Nov 2007 12:59:06 -0500 Date: Sun, 11 Nov 2007 12:03:48 -0600 From: Carlo Marcelo Arenas Belon Subject: Re: [Qemu-devel] error compiling hw/sh7750.c Message-ID: <20071111180348.GB9387@tapir> References: <20071111093026.NJ0KX.29116.root@eastrmwml27.mgt.cox.net> <20071111160634.GF25322@tapir> <20071111172122.GA9387@tapir> <200711111724.08081.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200711111724.08081.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Sun, Nov 11, 2007 at 05:24:06PM +0000, Paul Brook wrote: > > +#undef NULL > > +#define NULL ((void *)0) > > Absolutely not. this was not meant to be a final solution, or even be committed in qemu, just a stop gap solution answering Ben so that he can get their build to complete and have a somehow equivalent definition of what the code is doing in linux (where I presume was tested) until it can be fixed in a portable way. Ben's solution was to replace _INTC_ARRAY(NULL) with "NULL, NULL" but it should had been instead "NULL, 4" or "NULL, 8" depending on what ISA he is compiling it for, doing the "#undef/#define" leads to that and, yes I agree it is awful. Carlo