From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IrKCB-0001GT-9S
	for qemu-devel@nongnu.org; Sun, 11 Nov 2007 16:18:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IrKC9-0001GD-Jp
	for qemu-devel@nongnu.org; Sun, 11 Nov 2007 16:18:18 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IrKC9-0001GA-Hq
	for qemu-devel@nongnu.org; Sun, 11 Nov 2007 16:18:17 -0500
Received: from mail.gmx.net ([213.165.64.20])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <ThomasBleher@gmx.de>) id 1IrKC9-0007NK-2C
	for qemu-devel@nongnu.org; Sun, 11 Nov 2007 16:18:17 -0500
Date: Sun, 11 Nov 2007 22:18:09 +0100
From: Thomas Bleher <ThomasBleher@gmx.de>
Subject: Re: [Qemu-devel] [PATCH] Add TPM support
Message-ID: <20071111211808.GB7485@thomas>
References: <20071031125438.GG7712@networkno.de> <20071031141020.GC7567@thomas>
	<20071031161427.GI7712@networkno.de>
	<20071101155556.GC15568@thomas> <20071105141528.GE8650@thomas>
	<472F3966.1090206@bellard.org> <20071106080734.GB7621@thomas>
	<4730C497.5070201@bellard.org> <20071107120530.GC7624@thomas>
	<4731E7E3.4020602@bellard.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <4731E7E3.4020602@bellard.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

* Fabrice Bellard <fabrice@bellard.org> [2007-11-07 18:35]:
> A few more remarks :
>=20
> - tpm_register() must be called in hw/pc.c.
>=20
> - you must also handle incomplete write and reads. Use something like
> unix_write() in vl.c and the equivalent for read.
>=20
> - The code seems to be Unix specific so it must be disabled for win32.

Thank you for the comments. I had hoped to have some time this weekend
to fix these issues, but this wasn't the case. I've put them on my TODO
list and will resubmit once the issues are fixed.

Regards,
Thomas