From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IsPvo-00058I-F4 for qemu-devel@nongnu.org; Wed, 14 Nov 2007 16:37:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IsPvn-00057j-Fa for qemu-devel@nongnu.org; Wed, 14 Nov 2007 16:37:56 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IsPvn-00057g-DB for qemu-devel@nongnu.org; Wed, 14 Nov 2007 16:37:55 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IsPvm-00066Q-Rb for qemu-devel@nongnu.org; Wed, 14 Nov 2007 16:37:55 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] target_posix_types.h Date: Wed, 14 Nov 2007 21:37:46 +0000 References: <1195055987.918.34.camel@phantasm.home.enterpriseandprosperity.com> <200711142039.38427.paul@codesourcery.com> <1195075167.918.103.camel@phantasm.home.enterpriseandprosperity.com> In-Reply-To: <1195075167.918.103.camel@phantasm.home.enterpriseandprosperity.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711142137.48495.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: thayne@c2.net Cc: qemu-devel@nongnu.org > time_t is only one example. There are similar problems with the > handling of struct target_iovec. There are still other places with > similar problems. > > Yes, special casing can work. There's the possible problem of value > truncation when moving between 32 and 64 bits. My point is that I expect there the be sufficiently many special cases that you can't simply rely on get_user() doing the right thing, even if you have "proper" types everywhere. It's also unclear whether sign extensions should depend on host or guest properties. Paul