From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "J. Mayer" <l_indien@magic.fr>
Subject: Re: [Qemu-devel] RFC: fix for random Qemu crashes
Date: Fri, 16 Nov 2007 15:52:54 +0000 [thread overview]
Message-ID: <200711161552.55645.paul@codesourcery.com> (raw)
In-Reply-To: <1195168693.2415.19.camel@rapid>
> Then, I choosed to replace 'inline' by 'always_inline', which is more
> invasive but have less risks of side effects. The diff is attached in
> always_inline.diff.
> The last thing that helps solve the problem is to change the inlining
> limits of gcc, at least to compile the op.o file.
Presumably we only need one of the last two patches? It seems rather pointless
to have always_inline *and* change the inlining heuristics.
I'm ok with using always_inline for op.o (and things it uses directly) as this
is required for correctness. I'm not convinced that that using always_inline
everywhere is such a good idea.
Paul
next prev parent reply other threads:[~2007-11-16 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 23:18 [Qemu-devel] RFC: fix for random Qemu crashes J. Mayer
2007-11-15 23:49 ` andrzej zaborowski
2007-11-16 0:09 ` J. Mayer
2007-11-16 15:06 ` Heikki Lindholm
2007-11-16 15:35 ` Jocelyn Mayer
2007-11-16 15:42 ` Heikki Lindholm
2007-11-16 16:34 ` Jocelyn Mayer
2007-11-16 15:59 ` Jamie Lokier
2007-11-16 20:13 ` Jocelyn Mayer
2007-11-16 15:52 ` Paul Brook [this message]
2007-11-16 16:05 ` Jocelyn Mayer
2007-11-16 20:32 ` andrzej zaborowski
2007-11-17 0:04 ` J. Mayer
2007-11-17 2:58 ` [Qemu-devel] " Ben Pfaff
2007-11-17 8:22 ` J. Mayer
2007-11-17 10:57 ` [Qemu-devel] " andrzej zaborowski
2007-11-17 11:13 ` J. Mayer
-- strict thread matches above, loose matches on Subject: below --
2007-11-18 15:48 [Qemu-devel] [RFC] Fix " J. Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711161552.55645.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).