From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1It3V8-0004Gg-F6 for qemu-devel@nongnu.org; Fri, 16 Nov 2007 10:53:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1It3V7-0004Em-2k for qemu-devel@nongnu.org; Fri, 16 Nov 2007 10:53:02 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1It3V6-0004Ea-R8 for qemu-devel@nongnu.org; Fri, 16 Nov 2007 10:53:00 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1It3V6-0005K9-3R for qemu-devel@nongnu.org; Fri, 16 Nov 2007 10:53:00 -0500 From: Paul Brook Subject: Re: [Qemu-devel] RFC: fix for random Qemu crashes Date: Fri, 16 Nov 2007 15:52:54 +0000 References: <1195168693.2415.19.camel@rapid> In-Reply-To: <1195168693.2415.19.camel@rapid> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711161552.55645.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "J. Mayer" > Then, I choosed to replace 'inline' by 'always_inline', which is more > invasive but have less risks of side effects. The diff is attached in > always_inline.diff. > The last thing that helps solve the problem is to change the inlining > limits of gcc, at least to compile the op.o file. Presumably we only need one of the last two patches? It seems rather pointless to have always_inline *and* change the inlining heuristics. I'm ok with using always_inline for op.o (and things it uses directly) as this is required for correctness. I'm not convinced that that using always_inline everywhere is such a good idea. Paul