From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1It6Cp-0002zR-9e for qemu-devel@nongnu.org; Fri, 16 Nov 2007 13:46:19 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1It6Cm-0002u7-VC for qemu-devel@nongnu.org; Fri, 16 Nov 2007 13:46:18 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1It6Cm-0002tZ-Lk for qemu-devel@nongnu.org; Fri, 16 Nov 2007 13:46:16 -0500 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1It6Cl-0005xO-Rm for qemu-devel@nongnu.org; Fri, 16 Nov 2007 13:46:15 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lAGIk903024837 for ; Fri, 16 Nov 2007 13:46:09 -0500 Received: from file.surrey.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAGIk8OL025739 for ; Fri, 16 Nov 2007 13:46:09 -0500 Received: (from berrange@localhost) by file.surrey.redhat.com (8.13.1/8.13.1/Submit) id lAGIk8YV003880 for qemu-devel@nongnu.org; Fri, 16 Nov 2007 18:46:08 GMT Date: Fri, 16 Nov 2007 18:46:08 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] Collecting block device statistics Message-ID: <20071116184608.GA2956@redhat.com> References: <473DB76C.8050109@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <473DB76C.8050109@redhat.com> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Fri, Nov 16, 2007 at 03:29:48PM +0000, Richard W.M. Jones wrote: > Hi, > > I was looking for a way to collect information on the amount of data > being written and read from block devices. The attached patch adds a > few counters to the BlockDriverState structure to collect this > information, and a new "info blockstats" monitor command to display it. > > This screenshot shows it in action: > > http://www.annexia.org/tmp/Screenshot-QEMU.png > > This is the sort of feature I'd really like to see merged into qemu > because it will let us enhance libvirt to centrally collect these stats > from qemu instances. It looks good to me - this would be a very useful feature addition. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|