From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IuZvn-0007Cb-1I
	for qemu-devel@nongnu.org; Tue, 20 Nov 2007 15:42:51 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IuZvm-0007AC-2M
	for qemu-devel@nongnu.org; Tue, 20 Nov 2007 15:42:50 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IuZvl-00079x-Uf
	for qemu-devel@nongnu.org; Tue, 20 Nov 2007 15:42:49 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1IuZvl-00035R-Fy
	for qemu-devel@nongnu.org; Tue, 20 Nov 2007 15:42:49 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] qemu fpu/softfloat-specialize.h fpu/softfloat.c...
Date: Tue, 20 Nov 2007 20:42:41 +0000
References: <E1ItlDA-0001A5-GZ@localhost.localdomain>
	<f43fc5580711201217q7c96a02m427431bbef86b035@mail.gmail.com>
In-Reply-To: <f43fc5580711201217q7c96a02m427431bbef86b035@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200711202042.42465.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

> > Log message:
> >         Add strict checking mode for softfp code.
>
> This commit has broken sparc-softmmu,

Strange. My intention was for this commit to have absolutely no functional=
=20
changes.

=46WIW I verified that the debian-sparc installer image booted successfully=
=2E I=20
guess this probably doesn't stress the FPU much though.

> This and a couple similar changes look suspicious:
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&& ( (sbits64) ( zSig + roundInc=
rement ) < 0 ) )
> =C2=A0 =C2=A0 ) {
> =C2=A0 =C2=A0 =C2=A0float_raise( float_flag_overflow | float_flag_inexact=
 STATUS_VAR);
> - =C2=A0 =C2=A0return packFloat64( zSign, 0x7FF, 0 ) - ( roundIncrement =
=3D=3D 0 );
> + =C2=A0 =C2=A0return packFloat64( zSign, 0x7FF, - ( roundIncrement =3D=
=3D 0 )); }

I'm pretty sure this change is correct. ie. it has no effect on the result.

Paul