From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IxNpr-0000D4-3t
	for qemu-devel@nongnu.org; Wed, 28 Nov 2007 09:24:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IxNpm-0000B9-Gk
	for qemu-devel@nongnu.org; Wed, 28 Nov 2007 09:24:18 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IxNpm-0000B6-9I
	for qemu-devel@nongnu.org; Wed, 28 Nov 2007 09:24:14 -0500
Received: from smtp.citrix.com ([66.165.176.89])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1IxNpm-0008WF-69
	for qemu-devel@nongnu.org; Wed, 28 Nov 2007 09:24:14 -0500
Date: Wed, 28 Nov 2007 14:24:09 +0000
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"
Message-ID: <20071128142409.GF4083@implementation.uk.xensource.com>
References: <11962585701617@bull.net> <1196258570752@bull.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1196258570752@bull.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org

Hi,

Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a écrit :
> +    ret = posix_memalign((void**)&buf, 0x200, 512);

For making this more easily portable, maybe it should be a new
qemu_memalign() function?  Also, the alignment may probably be better as
a global macro, since the alignment requirements depend on the OS.

Samuel