qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] Open disk images with O_DIRECT
Date: Wed, 28 Nov 2007 14:27:39 +0000	[thread overview]
Message-ID: <20071128142739.GA7379@redhat.com> (raw)
In-Reply-To: <11962585701617@bull.net>

On Wed, Nov 28, 2007 at 03:02:50PM +0100, Laurent Vivier wrote:
> These patches allow to open file using O_DIRECT and bypass the host I/O cache.
>
> [PATCH 1/2] Add "directio" parameter to "-drive"
> 
>     Using "directio=on" with "-drive" will open the disk image 
>     file using "O_DIRECT".

I don't see the point in adding a config param for this. If it provides a
useful performance improvement (or other benefit) we should enable it by 
default all the time.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

  parent reply	other threads:[~2007-11-28 14:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28 14:02 [Qemu-devel] [PATCH 0/2] Open disk images with O_DIRECT Laurent Vivier
2007-11-28 14:02 ` [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive" Laurent Vivier
2007-11-28 14:02   ` [Qemu-devel] [PATCH 2/2] Direct IDE I/O Laurent Vivier
2007-11-28 14:24   ` [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive" Samuel Thibault
2007-11-28 15:00     ` Laurent Vivier
2007-11-28 15:08       ` Samuel Thibault
2007-11-29  9:40     ` Laurent Vivier
2007-11-28 14:27 ` Daniel P. Berrange [this message]
2007-11-28 14:34   ` [Qemu-devel] [PATCH 0/2] Open disk images with O_DIRECT Samuel Thibault
2007-11-28 14:58     ` Anthony Liguori
2007-11-28 15:08     ` Daniel P. Berrange
2007-11-28 15:17       ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071128142739.GA7379@redhat.com \
    --to=berrange@redhat.com \
    --cc=Laurent.Vivier@bull.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).