From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IxNto-00025I-1v for qemu-devel@nongnu.org; Wed, 28 Nov 2007 09:28:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IxNtm-00024Y-37 for qemu-devel@nongnu.org; Wed, 28 Nov 2007 09:28:22 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IxNtl-00024V-Uh for qemu-devel@nongnu.org; Wed, 28 Nov 2007 09:28:22 -0500 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IxNtm-000117-0o for qemu-devel@nongnu.org; Wed, 28 Nov 2007 09:28:22 -0500 Date: Wed, 28 Nov 2007 14:27:39 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 0/2] Open disk images with O_DIRECT Message-ID: <20071128142739.GA7379@redhat.com> References: <11962585701617@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11962585701617@bull.net> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org On Wed, Nov 28, 2007 at 03:02:50PM +0100, Laurent Vivier wrote: > These patches allow to open file using O_DIRECT and bypass the host I/O cache. > > [PATCH 1/2] Add "directio" parameter to "-drive" > > Using "directio=on" with "-drive" will open the disk image > file using "O_DIRECT". I don't see the point in adding a config param for this. If it provides a useful performance improvement (or other benefit) we should enable it by default all the time. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|