From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iy7aB-00074x-U1 for qemu-devel@nongnu.org; Fri, 30 Nov 2007 10:15:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iy7aA-00072l-35 for qemu-devel@nongnu.org; Fri, 30 Nov 2007 10:15:11 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iy7a9-00072X-UF for qemu-devel@nongnu.org; Fri, 30 Nov 2007 10:15:10 -0500 Received: from tapir.sajinet.com.pe ([66.139.79.212]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iy7a9-0001RC-9Q for qemu-devel@nongnu.org; Fri, 30 Nov 2007 10:15:09 -0500 Date: Fri, 30 Nov 2007 09:21:26 -0600 From: Carlo Marcelo Arenas Belon Subject: Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t Message-ID: <20071130152126.GC28369@tapir> References: <20071111154922.GE25322@tapir> <20071118211837.GA15962@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Fri, Nov 30, 2007 at 02:36:32PM +0900, Magnus Damm wrote: > On Nov 19, 2007 6:18 AM, Carlo Marcelo Arenas Belon > wrote: > > The following patch changes the formatting string from %08x to TARGET_FMT_plx > > to accommodate for compilation in 64bit hosts and that manifests with the > > following warning : > > > > qemu/hw/sh7750.c: In function `error_access': > > qemu/hw/sh7750.c:186: warning: unsigned int format, different type arg (arg 5) > > qemu/hw/sh7750.c: In function `ignore_access': > > qemu/hw/sh7750.c:192: warning: unsigned int format, different type arg (arg 5) > > This patch works fine on 32 bit x86 hosts. Please apply. Thanks, forgot to mention that I tested it of course as well in 32 bit x86 where the code is equivalent as cpu-defs.h defines for 32 bit targets : #define TARGET_FMT_plx "%08x" For 64 bit targets, it will use a 64 bit type for physical addresses and therefore a 64 bit wide format as defined by : #define TARGET_FMT_plx "%016" PRIx64 which might not be what was intended originally and might be uncovering a bug somewhere else and based on the fact that apparently (and this gets confusing as it seems to be inconsistently used everywhere in qemu) : target_phys_addr_t = physical address of the host ram_addr_t = physical address of the guest and so all this function should had been using ram_addr_t instead, and that would need to be redefined to be 64 bit safe and have as well a new formatting string to match that. > > Index: sh7750.c > > =================================================================== > > RCS file: /sources/qemu/qemu/hw/sh7750.c,v > > retrieving revision 1.11 > > diff -u -r1.11 sh7750.c > > --- sh7750.c 17 Nov 2007 17:14:48 -0000 1.11 > > +++ sh7750.c 18 Nov 2007 21:08:37 -0000 > > Could you please create the diff from the top level directory next > time? That way it can be applied with patch -p0 or -p1 directly in the > top level directory which makes patch handling much easier. Thanks! sure, sorry about that, made the mistake when rebasing the patch for this RESEND after a week has past without any feedback. Carlo