From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t
Date: Fri, 30 Nov 2007 16:50:55 +0000 [thread overview]
Message-ID: <200711301650.55751.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580711300737y16a91e9bu3308a26122df4c8e@mail.gmail.com>
> > target_phys_addr_t = physical address of the host
> > ram_addr_t = physical address of the guest
>
> No, target_phys_addr_t is the physical address of the emulated target
> system. For host addresses ram_addr_t, unsigned long or even int is
> used. Host addresses are of course virtual, Qemu is a user space
> application until someone makes it run in bare metal without OS.
Int should never be used to hold an address of any kind, and long probably
shouldn't either. The only time you should use these is where you've got a
known small offset, e.g after you've subtracted a base (physical) address to
get an offset within an MMIO region.
Some of the arm devices use uint32_t for addresses, which is really a bug. We
get away with it because these are only ever used by 32-bit targets.
target_ulong = target virtual address.
target_phys_addr_t = target physical address. Because of the way TLB handling
works these occasionally need to hold a host address. However these uses are
local to the internals of the TLB code, and should never occur anywhere else.
In general all access to target memory should be via
cpu_physcial_memory_{rw,read,write}
For performance reasons we currently make an exception for framebuffer devices
and allow them to access ram directly. ram_addr_t holds an offset from
phys_ram_base.
If you do for some reason have a host address you should use real host
pointers.
Usermode emulation complicates things a bit, but this isn't relevant for any
of the code in hw/.
Paul
next prev parent reply other threads:[~2007-11-30 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 15:49 [Qemu-devel] [PATCH] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t Carlo Marcelo Arenas Belon
2007-11-18 21:18 ` [Qemu-devel] [PATCH] [RESEND] " Carlo Marcelo Arenas Belon
2007-11-30 5:36 ` Magnus Damm
2007-11-30 15:21 ` Carlo Marcelo Arenas Belon
2007-11-30 15:37 ` Blue Swirl
2007-11-30 16:11 ` Carlo Marcelo Arenas Belon
2007-11-30 16:50 ` Paul Brook [this message]
2007-11-30 17:16 ` Blue Swirl
2007-11-30 17:42 ` Paul Brook
2007-11-30 18:45 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711301650.55751.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).