From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IyrtY-0004d4-1X
	for qemu-devel@nongnu.org; Sun, 02 Dec 2007 11:42:16 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IyrtV-0004bo-3Q
	for qemu-devel@nongnu.org; Sun, 02 Dec 2007 11:42:15 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IyrtU-0004bg-Qy
	for qemu-devel@nongnu.org; Sun, 02 Dec 2007 11:42:12 -0500
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1IyrtU-00014M-EB
	for qemu-devel@nongnu.org; Sun, 02 Dec 2007 11:42:12 -0500
Date: Sun, 2 Dec 2007 16:42:05 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [RFC] Ensure SIGALRM causes a cpu_loop_exit
Message-ID: <20071202164204.GD617@networkno.de>
References: <fb249edb0711231450u5f2405e9h1f36ec879afa114e@mail.gmail.com>
	<200711232343.37131.paul@codesourcery.com>
	<fb249edb0711241513t16a6074ekb472850a14dd30a5@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fb249edb0711241513t16a6074ekb472850a14dd30a5@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

andrzej zaborowski wrote:
> On 24/11/2007, Paul Brook <paul@codesourcery.com> wrote:
> > > There is a chance that when using "unix" or "dynticks" clock, the
> > > signal arrives when no cpu is executing.
> 
> How about this version, this one touches vl.c only:

Any reason why this isn't in CVS?


Thiemo

> --- a/vl.c
> +++ b/vl.c
> @@ -236,6 +236,10 @@ const char *prom_envs[MAX_PROM_ENVS];
>  struct bt_piconet_s *local_piconet;
>  struct modem_ops_s modem_ops;
> 
> +static CPUState *cur_cpu;
> +static CPUState *next_cpu;
> +static int event_pending;
> +
>  #define TFR(expr) do { if ((expr) != -1) break; } while (errno == EINTR)
> 
>  /***********************************************************/
> @@ -1183,16 +1187,16 @@ static void host_alarm_handler(int host_signum)
>          struct qemu_alarm_win32 *data = ((struct
> qemu_alarm_timer*)dwUser)->priv;
>          SetEvent(data->host_alarm);
>  #endif
> -        CPUState *env = cpu_single_env;
> -        if (env) {
> -            /* stop the currently executing cpu because a timer occured */
> -            cpu_interrupt(env, CPU_INTERRUPT_EXIT);
> +        CPUState *env = next_cpu;
> +
> +        /* stop the currently executing cpu because a timer occured */
> +        cpu_interrupt(env, CPU_INTERRUPT_EXIT);
>  #ifdef USE_KQEMU
> -            if (env->kqemu_enabled) {
> -                kqemu_cpu_interrupt(env);
> -            }
> -#endif
> +        if (env->kqemu_enabled) {
> +            kqemu_cpu_interrupt(env);
>          }
> +#endif
> +        event_pending = 1;
>      }
>  }
> 
> @@ -7168,8 +7172,6 @@ void main_loop_wait(int timeout)
> 
>  }
> 
> -static CPUState *cur_cpu;
> -
>  static int main_loop(void)
>  {
>      int ret, timeout;
> @@ -7179,15 +7181,13 @@ static int main_loop(void)
>      CPUState *env;
> 
>      cur_cpu = first_cpu;
> +    next_cpu = cur_cpu->next_cpu ?: first_cpu;
>      for(;;) {
>          if (vm_running) {
> 
> -            env = cur_cpu;
>              for(;;) {
>                  /* get next cpu */
> -                env = env->next_cpu;
> -                if (!env)
> -                    env = first_cpu;
> +                env = next_cpu;
>  #ifdef CONFIG_PROFILER
>                  ti = profile_getclock();
>  #endif
> @@ -7195,6 +7195,12 @@ static int main_loop(void)
>  #ifdef CONFIG_PROFILER
>                  qemu_time += profile_getclock() - ti;
>  #endif
> +                next_cpu = env->next_cpu ?: first_cpu;
> +                if (event_pending) {
> +                    ret = EXCP_INTERRUPT;
> +                    event_pending = 0;
> +                    break;
> +                }
>                  if (ret == EXCP_HLT) {
>                      /* Give the next CPU a chance to run.  */
>                      cur_cpu = env;
> 
> 
>