From: Thiemo Seufer <ths@networkno.de>
To: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu block-vvfat.c block.c console.c dyngen.c e...
Date: Sun, 2 Dec 2007 17:11:39 +0000 [thread overview]
Message-ID: <20071202171139.GE617@networkno.de> (raw)
In-Reply-To: <b2fa41d60711201417t4c0d6e7fr92cf501c45a3795d@mail.gmail.com>
Igor Kovalenko wrote:
> On Nov 18, 2007 4:44 AM, Paul Brook <paul@nowt.org> wrote:
> > CVSROOT: /sources/qemu
> > Module name: qemu
> > Changes by: Paul Brook <pbrook> 07/11/18 01:44:38
> >
> > Modified files:
> > . : block-vvfat.c block.c console.c dyngen.c
> > elf_ops.h i386-dis.c loader.c monitor.c osdep.c
> > qemu-char.h translate-op.c usb-linux.c vl.c
> > vnc.c x_keymap.c
> > audio : audio.c
> > hw : arm_sysctl.c arm_timer.c gt64xxx.c i8259.c
> > ide.c mc146818rtc.c mcf_fec.c mips_malta.c
> > ne2000.c nvram.h omap.c omap.h omap_lcdc.c
> > parallel.c pc.c pci.c pckbd.c piix_pci.c
> > pl061.c pl190.c pxa2xx_lcd.c pxa2xx_pcmcia.c
> > realview_gic.c rtl8139.c sd.c sh_serial.c
> > sh_timer.c smbus.c stellaris.c usb-ohci.c
> > wm8750.c
> > target-i386 : helper.c
> >
> > Log message:
> > Add statics and missing #includes for prototypes.
> >
>
> Here is a patch to hw/rtl8139.c which makes it reuse eeprom
> implementation available in eeprom93xx.
Introduces some warnings. I figure reading the eeprom contents back
is done incorrectly.
/home/ths/qemu/qemu-work/hw/rtl8139.c: In function `rtl8139_load':
/home/ths/qemu/qemu-work/hw/rtl8139.c:3072: warning: passing arg 2 of `qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3073: warning: passing arg 2 of `qemu_get_be16s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3074: warning: passing arg 2 of `qemu_get_be16s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3076: warning: passing arg 2 of `qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3077: warning: passing arg 2 of `qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3078: warning: passing arg 2 of `qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3079: warning: passing arg 2 of `qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3063: warning: unused variable `eeprom_contents'
Thiemo
prev parent reply other threads:[~2007-12-02 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 1:44 [Qemu-devel] qemu block-vvfat.c block.c console.c dyngen.c e Paul Brook
2007-11-20 22:17 ` Igor Kovalenko
2007-12-02 17:11 ` Thiemo Seufer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071202171139.GE617@networkno.de \
--to=ths@networkno.de \
--cc=igor.v.kovalenko@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).