From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J0f2c-0003SS-Pi
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 10:23:02 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J0f2b-0003Pa-Ia
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 10:23:02 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J0f2b-0003PC-Bz
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 10:23:01 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1J0f2a-0001EQ-TC
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 10:23:01 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] Real SCSI device passthrough (v3)
Date: Fri, 7 Dec 2007 15:22:53 +0000
References: <11970374183207@bull.net>
In-Reply-To: <11970374183207@bull.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200712071522.54416.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Laurent Vivier <Laurent.Vivier@bull.net>

On Friday 07 December 2007, Laurent Vivier wrote:
> - =A0 =A0acb->aiocb.aio_nbytes =3D nb_sectors * 512;
> + =A0 =A0if (nb_sectors < 0)
> + =A0 =A0 =A0 =A0acb->aiocb.aio_nbytes =3D -nb_sectors;
> + =A0 =A0else
> + =A0 =A0 =A0 =A0acb->aiocb.aio_nbytes =3D nb_sectors * 512;

Ugly hacks like this need at least a decent comment.

Paul