From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J0kVh-0005Rv-DP
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 16:13:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J0kVg-0005PF-6S
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 16:13:24 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J0kVf-0005Oq-KS
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 16:13:23 -0500
Received: from e31.co.us.ibm.com ([32.97.110.149])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ryanh@us.ibm.com>) id 1J0kVf-0007G8-8W
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 16:13:23 -0500
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e31.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id lB7LDLhv001648
	for <qemu-devel@nongnu.org>; Fri, 7 Dec 2007 16:13:21 -0500
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id
	lB7LDK4w032502
	for <qemu-devel@nongnu.org>; Fri, 7 Dec 2007 14:13:20 -0700
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	lB7LDJln013909
	for <qemu-devel@nongnu.org>; Fri, 7 Dec 2007 14:13:19 -0700
Date: Fri, 7 Dec 2007 15:13:18 -0600
From: Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI
	tables to PC machines
Message-ID: <20071207211318.GG23913@us.ibm.com>
References: <37bf559ffcf74bfe62ec.1197059815@localhost.localdomain>
	<4759B1A9.5080302@codemonkey.ws>
	<20071207205250.GF23913@us.ibm.com>
	<4759B559.1070405@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4759B559.1070405@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kvm-devel@lists.sourceforge.net, Ryan Harper <ryanh@us.ibm.com>, qemu-devel@nongnu.org

* Anthony Liguori <anthony@codemonkey.ws> [2007-12-07 15:07]:
> Ryan Harper wrote:
> >* Anthony Liguori <anthony@codemonkey.ws> [2007-12-07 14:49]:
> >  
> >>>+
> >>>+CPUState *first_cpu;
> >>> 
> >>>      
> >>This should probably be static.
> >>    
> >
> >doh, should be extern actually since it's defined elsewhere.
> >  
> 
> Perhaps you want cpu_single_env instead of first_cpu?

I wasn't quite sure given the comments surrounding its declaration:

from exec.c:

CPUState *first_cpu;
/* current CPU in the current thread. It is only valid inside
      cpu_exec() */
CPUState *cpu_single_env;


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@us.ibm.com