From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Dan Kenigsberg <danken@qumranet.com>
Subject: Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option
Date: Sun, 9 Dec 2007 11:36:34 +0000 [thread overview]
Message-ID: <200712091136.36900.paul@codesourcery.com> (raw)
In-Reply-To: <20071209092721.GA2858@karma.qumranet.com>
> + x86_cpu_def->vendor1 = cpu_to_le32(*(uint32_t *)val);
> + x86_cpu_def->vendor2 = cpu_to_le32(*(uint32_t *)(val +
> 4)); + x86_cpu_def->vendor3 = cpu_to_le32(*(uint32_t *)(val
Still not good enough. val might not be aligned.
Paul
next prev parent reply other threads:[~2007-12-09 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 13:23 [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option Dan Kenigsberg
2007-12-09 3:02 ` Thiemo Seufer
2007-12-09 9:27 ` Dan Kenigsberg
2007-12-09 11:36 ` Paul Brook [this message]
2007-12-09 13:52 ` Dan Kenigsberg
2007-12-09 18:29 ` Andreas Schwab
2007-12-09 18:58 ` Dan Kenigsberg
2007-12-09 20:00 ` Dan Kenigsberg
2007-12-20 16:40 ` [Qemu-devel] [PATCH] Allow setting the vendor and model_id strings " Dan Kenigsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712091136.36900.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=danken@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).