From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J1KSj-00046f-63
	for qemu-devel@nongnu.org; Sun, 09 Dec 2007 06:36:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J1KSh-00045n-Nc
	for qemu-devel@nongnu.org; Sun, 09 Dec 2007 06:36:43 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J1KSh-00045k-HO
	for qemu-devel@nongnu.org; Sun, 09 Dec 2007 06:36:43 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1J1KSh-0004Y0-4Q
	for qemu-devel@nongnu.org; Sun, 09 Dec 2007 06:36:43 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with
	x86's -cpu option
Date: Sun, 9 Dec 2007 11:36:34 +0000
References: <20071125132334.GA9555@karma.qumranet.com>
	<20071209030244.GC12436@networkno.de>
	<20071209092721.GA2858@karma.qumranet.com>
In-Reply-To: <20071209092721.GA2858@karma.qumranet.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200712091136.36900.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Dan Kenigsberg <danken@qumranet.com>

> +                x86_cpu_def->vendor1 = cpu_to_le32(*(uint32_t *)val);
> +                x86_cpu_def->vendor2 = cpu_to_le32(*(uint32_t *)(val +
> 4)); +                x86_cpu_def->vendor3 = cpu_to_le32(*(uint32_t *)(val

Still not good enough. val might not be aligned.

Paul