From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J1l8g-0004EK-NM
	for qemu-devel@nongnu.org; Mon, 10 Dec 2007 11:05:50 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J1l8e-0004BC-S5
	for qemu-devel@nongnu.org; Mon, 10 Dec 2007 11:05:50 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J1l8e-0004Ar-IP
	for qemu-devel@nongnu.org; Mon, 10 Dec 2007 11:05:48 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1J1l8e-0004UH-27
	for qemu-devel@nongnu.org; Mon, 10 Dec 2007 11:05:48 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Capture network traffic to a tcpdump file
	=?utf-8?q?-=09updated?=
Date: Mon, 10 Dec 2007 16:05:38 +0000
References: <380128.17287.qm@web57002.mail.re3.yahoo.com>
	<475D5CF2.1020202@codemonkey.ws>
In-Reply-To: <475D5CF2.1020202@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200712101605.39168.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Monday 10 December 2007, Anthony Liguori wrote:
> Balazs Attila-Mihaly (Cd-MaN) wrote:
> > Here goes v0.2 for my patch :-)
> > Changes
> > - now the option is a separate command line switch:
> >   -net capture,vlan=2,file=test.pcap
>
> Is it really necessary/useful to specify this on the command line since
> it can be controlled from the monitor?

By that argument you could remove half the rest of the commandline options 
(e.g. the USB options).

I think it would be good to expose the whole -net functionality via the 
monitor, rather than have a special hack for -net monitor. Obviously some 
functionality would only be usable via the commandline (e.g. non-hotplug 
NICs).

Paul