From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2Dmq-0007ss-3h for qemu-devel@nongnu.org; Tue, 11 Dec 2007 17:41:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2Dml-0007ma-Jl for qemu-devel@nongnu.org; Tue, 11 Dec 2007 17:41:11 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2Dml-0007mN-Bh for qemu-devel@nongnu.org; Tue, 11 Dec 2007 17:41:07 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J2Dml-0001ka-6t for qemu-devel@nongnu.org; Tue, 11 Dec 2007 17:41:07 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Capture network traffic to a tcpdump file - updated Date: Tue, 11 Dec 2007 22:40:56 +0000 References: <380128.17287.qm@web57002.mail.re3.yahoo.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712112240.58482.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tuesday 11 December 2007, andrzej zaborowski wrote: > On 10/12/2007, Balazs Attila-Mihaly (Cd-MaN) wrote: > > Here goes v0.2 for my patch :-) > > Changes > > - now the option is a separate command line switch: > > -net capture,vlan=2,file=test.pcap > > - it is also available from the monitor > > - added some more constants / defines to avoid repeating portions of the > > code > > Would it be possible to implement this as simply another vlan client > that does the logging in it's fd_read callback? I think this would be > cleaner, we would avoid the special case and an additional condition > check in every qemu_send_packet(). That's exactly what I was imagining when I suggested making it a -net option. Paul