[Qemu-devel] [PATCH] SVM enabled processor should provide cpuid Fn8000_000A

[Qemu-devel] [PATCH] SVM enabled processor should provide cpuid Fn8000_000A

[Bernhard Kauer]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

An SVM enabled processor should provide the CPUID extended leaf Fn8000_000A
(see AMD documentation #25481). The attached patch add this feature.


	Bernhard Kauer

[-- Attachment #2: qemu_cpuid.diff --]
[-- Type: text/x-diff, Size: 1142 bytes --]

Index: target-i386/helper.c
===================================================================
RCS file: /sources/qemu/qemu/target-i386/helper.c,v
retrieving revision 1.97
diff -u -r1.97 helper.c
--- target-i386/helper.c	9 Dec 2007 23:39:22 -0000	1.97
+++ target-i386/helper.c	18 Dec 2007 12:40:06 -0000
@@ -1751,6 +1819,12 @@
         ECX = 0;
         EDX = 0;
         break;
+    case 0x8000000A:
+        EAX = 0x00000001;
+        EBX = 0;
+        ECX = 0;
+        EDX = 0;
+	break;
     default:
         /* reserved values: zero */
         EAX = 0;
Index: target-i386/helper2.c
===================================================================
RCS file: /sources/qemu/qemu/target-i386/helper2.c,v
retrieving revision 1.60
diff -u -r1.60 helper2.c
--- target-i386/helper2.c	9 Dec 2007 02:43:19 -0000	1.60
+++ target-i386/helper2.c	18 Dec 2007 12:40:06 -0000
@@ -150,7 +150,7 @@
         .ext2_features = (PPRO_FEATURES & 0x0183F3FF) | 
             CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX,
         .ext3_features = CPUID_EXT3_SVM,
-        .xlevel = 0x80000008,
+        .xlevel = 0x8000000A,
     },
 #endif
     {

Re: [Qemu-devel] [PATCH] SVM enabled processor should provide cpuid Fn8000_000A

[Alexander Graf]

Now that you're really using the SVM emulation, please bear in mind  
that the upper SVM exits don't work due to the 64-bit int limits. I  
haven't really found a proper solution for that, but in the meantime  
you can't intercept instructions like MONITOR or WBINVD, as they get  
shifted out of the TB identifier.

Just so you know.

On Dec 18, 2007, at 2:01 PM, Bernhard Kauer wrote:

> An SVM enabled processor should provide the CPUID extended leaf  
> Fn8000_000A
> (see AMD documentation #25481). The attached patch add this feature.
>
>
> 	Bernhard Kauer
> <qemu_cpuid.diff>

This one is really important as it makes current kvm versions run.  
Please apply.

Alex