qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "François Revol" <revol@free.fr>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: qemu-devel@nongnu.org
Subject: Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c	into usb-hid.c
Date: Wed, 29 Apr 2009 00:45:25 +0200 CEST	[thread overview]
Message-ID: <20079047219-BeMail@laptop> (raw)
In-Reply-To: <alpine.DEB.1.00.0904290025380.10279@pacific.mpi-cbg.de>

Hi,

> > > What bug does this solve?  And what is the advantage of making
> > > one
> > > file very large, when before, we had two files with relatively
> > > separate code?
> >
> > http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=40233
>
> Reading something like this in a Git log, sitting 30k feet above
> ground,
> makes me want to do something very foolish.

Sorry but I've argued it like 4 times already, I've been having this
diff sitting here for months, I've done it because I was told that
instead of fixing usb-wacom it should be merged, I've read so many git
manpages I have a headache, I spent last night trying to dig the overly
cryptic zlib code to see why it would crash the Haiku m68k floppy
loader, the time I spend on qemu stuff isn't spent on the projects for
which qemu is supposed to be a dev tool, I'm overdue for work, so I'm
just getting tired of it.

cf. the many results on
http://search.gmane.org/?query=usb-wacom&group=gmane.comp.emulators.qemu

> Besides, the explanation given in that email is somewhat slim.
> Experience
> shows that the number of bugs lurking in some random file is the
> square of
> the number of lines in that file, so...

Given that those lines are mostly the same that were removed from the
other file, minus the many that were identical and so factored out,
plus just a few that actually fix a scaling bug resp to the hardware,
making less as total, and so squared a lesser number of bugs, and that
I've explained it already too much I'd rather keep it slim instead of
adding english bugs, besides I'm french.

> But my advice has been ignored on this list before, so I'll start
> wasting
> my time elsewhere.

And my patch has been ignored several times too, still I'm here.

François.

  reply	other threads:[~2009-04-28 22:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 21:26 [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c François Revol
2009-04-28 22:10 ` *** GMX Spamverdacht *** " Johannes Schindelin
2009-04-28 22:22   ` François Revol
2009-04-28 22:29     ` Johannes Schindelin
2009-04-28 22:45       ` François Revol [this message]
2009-04-29  8:45         ` Johannes Schindelin
2009-04-29  9:30           ` François Revol
2009-04-29 10:01             ` Markus Armbruster
2009-04-29 10:23               ` François Revol
2009-04-29 16:27                 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20079047219-BeMail@laptop \
    --to=revol@free.fr \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).