qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter
Date: Fri, 4 Jan 2008 02:10:41 -0600	[thread overview]
Message-ID: <20080104081041.GB9968@tapir> (raw)

Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write
are from an array of the uint8_t type

Carlo

---
Index: block-vvfat.c
===================================================================
RCS file: /sources/qemu/qemu/block-vvfat.c,v
retrieving revision 1.16
diff -u -p -r1.16 block-vvfat.c
--- block-vvfat.c	24 Dec 2007 13:26:04 -0000	1.16
+++ block-vvfat.c	4 Jan 2008 07:57:20 -0000
@@ -340,7 +340,7 @@ typedef struct BDRVVVFATState {
     int current_fd;
     mapping_t* current_mapping;
     unsigned char* cluster; /* points to current cluster */
-    unsigned char* cluster_buffer; /* points to a buffer to hold temp data */
+    uint8_t* cluster_buffer; /* points to a buffer to hold temp data */
     unsigned int current_cluster;
 
     /* write support */
Index: block.c
===================================================================
RCS file: /sources/qemu/qemu/block.c,v
retrieving revision 1.53
diff -u -p -r1.53 block.c
--- block.c	24 Dec 2007 16:10:43 -0000	1.53
+++ block.c	4 Jan 2008 07:57:21 -0000
@@ -459,7 +459,7 @@ int bdrv_commit(BlockDriverState *bs)
     BlockDriver *drv = bs->drv;
     int64_t i, total_sectors;
     int n, j;
-    unsigned char sector[512];
+    uint8_t sector[512];
 
     if (!drv)
         return -ENOMEDIUM;

             reply	other threads:[~2008-01-04  8:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-04  8:10 Carlo Marcelo Arenas Belon [this message]
2008-01-04 13:20 ` [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter Thiemo Seufer
2008-01-04 13:41   ` Andreas Färber
2008-01-04 14:00     ` Samuel Thibault
2008-01-04 14:46       ` Andreas Färber
2008-01-04 16:14         ` Thiemo Seufer
2008-01-04 17:10         ` M. Warner Losh
2008-01-04 18:29     ` Andreas Schwab
2008-01-05  0:39     ` Rob Landley
2008-01-05  2:01   ` Carlo Marcelo Arenas Belon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080104081041.GB9968@tapir \
    --to=carenas@sajinet.com.pe \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).