From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JAmTe-00036x-Kb
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 08:20:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JAmTc-00036l-UR
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 08:20:46 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JAmTc-00036i-QG
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 08:20:44 -0500
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1JAmTc-00070M-ES
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 08:20:44 -0500
Date: Fri, 4 Jan 2008 13:20:39 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read,
	write} use (uint8_t *) for its third parameter
Message-ID: <20080104132039.GA22809@networkno.de>
References: <20080104081041.GB9968@tapir>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080104081041.GB9968@tapir>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
Cc: qemu-devel@nongnu.org

Carlo Marcelo Arenas Belon wrote:
> Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write
> are from an array of the uint8_t type

Do we have a host where this actually makes a difference?


Thiemo

> ---
> Index: block-vvfat.c
> ===================================================================
> RCS file: /sources/qemu/qemu/block-vvfat.c,v
> retrieving revision 1.16
> diff -u -p -r1.16 block-vvfat.c
> --- block-vvfat.c	24 Dec 2007 13:26:04 -0000	1.16
> +++ block-vvfat.c	4 Jan 2008 07:57:20 -0000
> @@ -340,7 +340,7 @@ typedef struct BDRVVVFATState {
>      int current_fd;
>      mapping_t* current_mapping;
>      unsigned char* cluster; /* points to current cluster */
> -    unsigned char* cluster_buffer; /* points to a buffer to hold temp data */
> +    uint8_t* cluster_buffer; /* points to a buffer to hold temp data */
>      unsigned int current_cluster;
>  
>      /* write support */
> Index: block.c
> ===================================================================
> RCS file: /sources/qemu/qemu/block.c,v
> retrieving revision 1.53
> diff -u -p -r1.53 block.c
> --- block.c	24 Dec 2007 16:10:43 -0000	1.53
> +++ block.c	4 Jan 2008 07:57:21 -0000
> @@ -459,7 +459,7 @@ int bdrv_commit(BlockDriverState *bs)
>      BlockDriver *drv = bs->drv;
>      int64_t i, total_sectors;
>      int n, j;
> -    unsigned char sector[512];
> +    uint8_t sector[512];
>  
>      if (!drv)
>          return -ENOMEDIUM;
> 
> 
>