From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter
Date: Fri, 4 Jan 2008 14:00:30 +0000 [thread overview]
Message-ID: <20080104140030.GH5666@implementation.uk.xensource.com> (raw)
In-Reply-To: <391FA8ED-AD24-4AFC-915E-5609235542F1@web.de>
Andreas Färber, le Fri 04 Jan 2008 14:41:29 +0100, a écrit :
>
> Am 04.01.2008 um 14:20 schrieb Thiemo Seufer:
>
> >Carlo Marcelo Arenas Belon wrote:
> >>Trivial fix that ensures that all buffers used for bdrv_read or
> >>bdrv_write
> >>are from an array of the uint8_t type
> >
> >Do we have a host where this actually makes a difference?
>
> I believe Perl makes sizeof(char) checks, so there likely is some
> platform where sizeof(char) > 1.
The C standard says
`When applied to an operand that has type char, unsigned char, or signed
char, (or a qualified version thereof) the result is 1.'
Samuel
next prev parent reply other threads:[~2008-01-04 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 8:10 [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter Carlo Marcelo Arenas Belon
2008-01-04 13:20 ` Thiemo Seufer
2008-01-04 13:41 ` Andreas Färber
2008-01-04 14:00 ` Samuel Thibault [this message]
2008-01-04 14:46 ` Andreas Färber
2008-01-04 16:14 ` Thiemo Seufer
2008-01-04 17:10 ` M. Warner Losh
2008-01-04 18:29 ` Andreas Schwab
2008-01-05 0:39 ` Rob Landley
2008-01-05 2:01 ` Carlo Marcelo Arenas Belon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104140030.GH5666@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).