From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JAn6z-0005SM-KO
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 09:01:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JAn6u-0005Px-87
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 09:01:23 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JAn6u-0005Pu-5V
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 09:01:20 -0500
Received: from smtp02.citrix.com ([66.165.176.63])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1JAn6t-00068F-NA
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 09:01:19 -0500
Received: from implementation.famille.thibault.fr
	(dhcp-16-192.uk.xensource.com [172.31.16.192])
	by smtp01.ad.xensource.com (8.13.1/8.13.1) with ESMTP id m04E0WHA007191
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO)
	for <qemu-devel@nongnu.org>; Fri, 4 Jan 2008 06:00:36 -0800
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.68) (envelope-from <samuel.thibault@labri.fr>) id 1JAn67-0003tg-8t
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 15:00:31 +0100
Date: Fri, 4 Jan 2008 14:00:30 +0000
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read,
	write} use (uint8_t *) for its third parameter
Message-ID: <20080104140030.GH5666@implementation.uk.xensource.com>
References: <20080104081041.GB9968@tapir> <20080104132039.GA22809@networkno.de>
	<391FA8ED-AD24-4AFC-915E-5609235542F1@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <391FA8ED-AD24-4AFC-915E-5609235542F1@web.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Andreas Färber, le Fri 04 Jan 2008 14:41:29 +0100, a écrit :
> 
> Am 04.01.2008 um 14:20 schrieb Thiemo Seufer:
> 
> >Carlo Marcelo Arenas Belon wrote:
> >>Trivial fix that ensures that all buffers used for bdrv_read or  
> >>bdrv_write
> >>are from an array of the uint8_t type
> >
> >Do we have a host where this actually makes a difference?
> 
> I believe Perl makes sizeof(char) checks, so there likely is some  
> platform where sizeof(char) > 1.

The C standard says

`When applied to an operand that has type char, unsigned char, or signed
char, (or a qualified version thereof) the result is 1.'

Samuel