From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JAx4E-0006KJ-Ei
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 19:39:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JAx4D-0006Iu-FT
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 19:39:14 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JAx4D-0006Ib-88
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 19:39:13 -0500
Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5]
	helo=grelber.thyrsus.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rob@landley.net>) id 1JAx4D-0006uv-51
	for qemu-devel@nongnu.org; Fri, 04 Jan 2008 19:39:13 -0500
From: Rob Landley <rob@landley.net>
Subject: Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read,
	write} use (uint8_t *) for its third parameter
Date: Fri, 4 Jan 2008 18:39:08 -0600
References: <20080104081041.GB9968@tapir> <20080104132039.GA22809@networkno.de>
	<391FA8ED-AD24-4AFC-915E-5609235542F1@web.de>
In-Reply-To: <391FA8ED-AD24-4AFC-915E-5609235542F1@web.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Disposition: inline
Message-Id: <200801041839.09074.rob@landley.net>
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Andreas =?iso-8859-1?q?F=E4rber?= <andreas.faerber@web.de>

On Friday 04 January 2008 07:41:29 Andreas F=E4rber wrote:
> Am 04.01.2008 um 14:20 schrieb Thiemo Seufer:
> > Carlo Marcelo Arenas Belon wrote:
> >> Trivial fix that ensures that all buffers used for bdrv_read or
> >> bdrv_write
> >> are from an array of the uint8_t type
> >
> > Do we have a host where this actually makes a difference?
>
> I believe Perl makes sizeof(char) checks, so there likely is some
> platform where sizeof(char) > 1.

There's a difference between "what some now-obsolete HP minicomputer once=
 did=20
in 1987" and "an interesting system with nonzero potential deployments".

A system with sizeof(char)!=3D1 does not fall in the second category.  In=
 fact,=20
on Unix, "short", "int", and "long" all have defined sizes too.

Standard:
  http://www.unix.org/whitepapers/64bit.html
Rationale document:
  http://www.unix.org/version2/whatsnew/lp64_wp.html

Infrastructure in search of a user always bit rots.  Wait for somebody to=
=20
complain, and _then_ add it, once a user has shown up who can test it (an=
d=20
detect its absence).

> Andreas

Rob
--=20
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.