qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support
Date: Fri, 4 Jan 2008 21:53:09 -0600	[thread overview]
Message-ID: <200801042153.09808.rob@landley.net> (raw)
In-Reply-To: <20080105010230.GA2230@miranda.arrow>

On Friday 04 January 2008 19:02:30 Stuart Brady wrote:
> On Fri, Jan 04, 2008 at 06:25:25PM -0600, Rob Landley wrote:
> > On Friday 04 January 2008 04:02:07 Carlo Marcelo Arenas Belon wrote:
> > > > -            buf[7] = total_sectors <= 1433600 ? 0x08 : 0x10; /*
> > > > current profile */
> >
> > Where does the constant come from, anyway?
>
> 1433600?  Seems it's the number of 512 KiB blocks in a 700 MiB CD image
> (700 * 1024 * 2).

Except that according to http://en.wikipedia.org/wiki/CD-ROM it's actually 703 
and 1/8 binary megabytes (360,000 sectors *2048 bytes), which would be 
1440000.

And we all know wikipedia's never wrong:
  http://www.theonion.com/content/node/50902 

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

  parent reply	other threads:[~2008-01-05  3:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-26  7:36 [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support Carlo Marcelo Arenas Belon
2008-01-04 10:02 ` Carlo Marcelo Arenas Belon
2008-01-05  0:25   ` Rob Landley
2008-01-05  1:02     ` Stuart Brady
2008-01-05  1:57       ` Stuart Brady
2008-01-05  2:06       ` Carlo Marcelo Arenas Belon
2008-01-05  3:53       ` Rob Landley [this message]
2008-01-05 10:28         ` Stuart Brady
2008-01-06  2:22           ` Carlo Marcelo Arenas Belon
2008-01-06 13:57             ` Stuart Brady
2008-01-06 14:32               ` Andreas Färber
2008-01-07  0:38                 ` Carlo Marcelo Arenas Belon
2008-01-07  0:23               ` Carlo Marcelo Arenas Belon
2008-01-05  3:36     ` Carlo Marcelo Arenas Belon
2008-01-06  9:22       ` Rob Landley
2008-01-07  4:47         ` Carlo Marcelo Arenas Belon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801042153.09808.rob@landley.net \
    --to=rob@landley.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).