From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JB060-0003CD-Oy for qemu-devel@nongnu.org; Fri, 04 Jan 2008 22:53:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JB05z-00039t-9b for qemu-devel@nongnu.org; Fri, 04 Jan 2008 22:53:16 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JB05z-00039n-6d for qemu-devel@nongnu.org; Fri, 04 Jan 2008 22:53:15 -0500 Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=grelber.thyrsus.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JB05y-0006d1-Sw for qemu-devel@nongnu.org; Fri, 04 Jan 2008 22:53:14 -0500 From: Rob Landley Subject: Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support Date: Fri, 4 Jan 2008 21:53:09 -0600 References: <20071226073615.GB25052@tapir> <200801041825.26304.rob@landley.net> <20080105010230.GA2230@miranda.arrow> In-Reply-To: <20080105010230.GA2230@miranda.arrow> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801042153.09808.rob@landley.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Friday 04 January 2008 19:02:30 Stuart Brady wrote: > On Fri, Jan 04, 2008 at 06:25:25PM -0600, Rob Landley wrote: > > On Friday 04 January 2008 04:02:07 Carlo Marcelo Arenas Belon wrote: > > > > - buf[7] = total_sectors <= 1433600 ? 0x08 : 0x10; /* > > > > current profile */ > > > > Where does the constant come from, anyway? > > 1433600? Seems it's the number of 512 KiB blocks in a 700 MiB CD image > (700 * 1024 * 2). Except that according to http://en.wikipedia.org/wiki/CD-ROM it's actually 703 and 1/8 binary megabytes (360,000 sectors *2048 bytes), which would be 1440000. And we all know wikipedia's never wrong: http://www.theonion.com/content/node/50902 Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson.