From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JBfrv-0002S8-6o for qemu-devel@nongnu.org; Sun, 06 Jan 2008 19:29:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JBfrs-0002O3-Kf for qemu-devel@nongnu.org; Sun, 06 Jan 2008 19:29:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JBfrs-0002Nj-DA for qemu-devel@nongnu.org; Sun, 06 Jan 2008 19:29:28 -0500 Received: from tapir.sajinet.com.pe ([66.139.79.212]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JBfrs-0004EP-38 for qemu-devel@nongnu.org; Sun, 06 Jan 2008 19:29:28 -0500 Date: Sun, 6 Jan 2008 18:38:54 -0600 From: Carlo Marcelo Arenas Belon Subject: Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support Message-ID: <20080107003854.GB23672@tapir> References: <20071226073615.GB25052@tapir> <200801041825.26304.rob@landley.net> <20080105010230.GA2230@miranda.arrow> <200801042153.09808.rob@landley.net> <20080105102834.GA3379@miranda.arrow> <20080106022233.GB27577@tapir> <20080106135738.GA5781@miranda.arrow> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, Jan 06, 2008 at 03:32:27PM +0100, Andreas F=C3=A4rber wrote: > Either way, shouldn't it be a preprocessor define rather than a magic =20 > number, maybe something like MAX_SECTORS_CD? Then it can more easily =20 > be found and changed, where necessary. Point taken, will fix that if we still have to rely on the number of sect= ors to detect the media type. Carlo