qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] ide: multi-profile DVD-ROM support v2
Date: Mon, 7 Jan 2008 15:36:12 +0000	[thread overview]
Message-ID: <200801071536.15936.paul@codesourcery.com> (raw)
In-Reply-To: <20080107122644.GE24641@tapir>

> +/* Some generally useful CD-ROM information */
> +#define CD_MINS                       99 /* max. minutes per CD */
> +#define CD_SECS                       60 /* seconds per minute */
> +#define CD_FRAMES                     75 /* frames per second */
> +#define CD_FRAMESIZE                2048 /* bytes per frame, "cooked" mode
> */ +#define CD_MAX_BYTES           912384000 /* multiply all of the above
> */ +#define CD_MAX_SECTORS           1782000 /* divide by 512 */

The last two should be calculated from the first, not hardcoded values.

Paul

  reply	other threads:[~2008-01-07 15:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 12:26 [Qemu-devel] [RFC] ide: multi-profile DVD-ROM support v2 Carlo Marcelo Arenas Belon
2008-01-07 15:36 ` Paul Brook [this message]
2008-01-08 12:45   ` [Qemu-devel] [RFC] ide: multi-profile DVD-ROM support v2.1 Carlo Marcelo Arenas Belon
2008-01-08 14:42     ` Thiemo Seufer
2008-01-09 12:57       ` [Qemu-devel] [PATCH] ide: multi-profile DVD-ROM support v2.2 Carlo Marcelo Arenas Belon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801071536.15936.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).