From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JBu1Y-0001S6-IQ
	for qemu-devel@nongnu.org; Mon, 07 Jan 2008 10:36:24 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JBu1X-0001Pv-7C
	for qemu-devel@nongnu.org; Mon, 07 Jan 2008 10:36:24 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JBu1X-0001Pa-1J
	for qemu-devel@nongnu.org; Mon, 07 Jan 2008 10:36:23 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JBu1W-0004XW-HO
	for qemu-devel@nongnu.org; Mon, 07 Jan 2008 10:36:22 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [RFC] ide: multi-profile DVD-ROM support v2
Date: Mon, 7 Jan 2008 15:36:12 +0000
References: <20080107122644.GE24641@tapir>
In-Reply-To: <20080107122644.GE24641@tapir>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200801071536.15936.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> +/* Some generally useful CD-ROM information */
> +#define CD_MINS                       99 /* max. minutes per CD */
> +#define CD_SECS                       60 /* seconds per minute */
> +#define CD_FRAMES                     75 /* frames per second */
> +#define CD_FRAMESIZE                2048 /* bytes per frame, "cooked" mode
> */ +#define CD_MAX_BYTES           912384000 /* multiply all of the above
> */ +#define CD_MAX_SECTORS           1782000 /* divide by 512 */

The last two should be calculated from the first, not hardcoded values.

Paul