From: Marcelo Tosatti <marcelo@kvack.org>
To: kvm-devel <kvm-devel@lists.sourceforge.net>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] report revision 3 of the ACPI/SMBus PIIX4 controller
Date: Fri, 11 Jan 2008 19:26:55 -0200 [thread overview]
Message-ID: <20080111212655.GA28753@dmt> (raw)
The PIIX4 ACPI controller prior to revision 0x3 contains a bug where
reading of the timer port is unreliable, so the kernel reads it three
times for consistency check.
QEMU does not suffer from that problem :)
The datasheet for PIIX4, PIIX4E, and PIIX4M is the same. I failed to
find any indication that the revision increase could affect anything
other than the PMTimer port read.
This reduces idle guest CPU consumption from 14% to 8% on 4-way KVM
guest.
--- kvm-userspace.orig/qemu/hw/acpi.c
+++ kvm-userspace/qemu/hw/acpi.c
@@ -486,7 +486,7 @@ i2c_bus *piix4_pm_init(PCIBus *bus, int
pci_conf[0x03] = 0x71;
pci_conf[0x06] = 0x80;
pci_conf[0x07] = 0x02;
- pci_conf[0x08] = 0x00; // revision number
+ pci_conf[0x08] = 0x03; // revision number
pci_conf[0x09] = 0x00;
pci_conf[0x0a] = 0x80; // other bridge device
pci_conf[0x0b] = 0x06; // bridge device
next reply other threads:[~2008-01-11 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 21:26 Marcelo Tosatti [this message]
2008-01-13 10:25 ` [Qemu-devel] Re: [kvm-devel] [PATCH] report revision 3 of the ACPI/SMBus PIIX4 controller Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080111212655.GA28753@dmt \
--to=marcelo@kvack.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).