qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eddie Kohler <kohler@cs.ucla.edu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] add VNC reverse connections
Date: Wed, 16 Jan 2008 16:35:39 +0000	[thread overview]
Message-ID: <20080116163539.GA27604@redhat.com> (raw)
In-Reply-To: <478E1E0F.1040303@cs.ucla.edu>

On Wed, Jan 16, 2008 at 07:09:03AM -0800, Eddie Kohler wrote:
> Daniel P. Berrange wrote:
> >We already have the ability to pass multiple flags / options to the VNC
> >driver as a post-fix to the host:port pair, so I'm not a fan of introducing
> >a new option as a prefix. If using existing options syntax, it could look
> >like:
> >
> >  -vnc :5500,rev
> >  -vnc read.cs.ucla.edu:5500,rev
> 
> This doesn't feel like an option to me, though; rather a different means of 
> connecting.  Among other things, in "-vnc :0", the QEMU VNC server opens 
> port 5900.  But the client's listening port for reverse connections 
> defaults to 5500.  "-vnc :-400,rev" is clearly insane, but it seems strange 
> for an option like ",rev" to change the meaning of the port field.

Yes that is a valid point. It is a little unfortunate we switched to using
display num instead of port num for the current VNC code. Having a syntax
which makes people use negative display nums for reverse connections would
suck. So reluctantly I think your original proposal may actually be better.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

  parent reply	other threads:[~2008-01-16 16:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16  7:27 [Qemu-devel] [PATCH] add VNC reverse connections Eddie Kohler
2008-01-16  8:55 ` Avi Kivity
2008-01-16 12:42 ` Daniel P. Berrange
2008-01-16 15:00   ` Anthony Liguori
2008-01-16 15:09   ` Eddie Kohler
2008-01-16 16:31     ` Anthony Liguori
2008-01-16 16:35     ` Daniel P. Berrange [this message]
2008-01-17  0:04       ` Anthony Liguori
2008-01-17  0:51         ` Eddie Kohler
2008-01-17 16:29         ` Eddie Kohler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080116163539.GA27604@redhat.com \
    --to=berrange@redhat.com \
    --cc=kohler@cs.ucla.edu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).