From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JFdTz-0002Ls-JZ for qemu-devel@nongnu.org; Thu, 17 Jan 2008 17:45:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JFdTu-0002F5-Hm for qemu-devel@nongnu.org; Thu, 17 Jan 2008 17:45:11 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JFdTu-0002Ea-77 for qemu-devel@nongnu.org; Thu, 17 Jan 2008 17:45:06 -0500 Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JFdTt-00079m-0p for qemu-devel@nongnu.org; Thu, 17 Jan 2008 17:45:05 -0500 Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com with ESMTP id <20080117224613.NOTS6201.mtaout01-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com> for ; Thu, 17 Jan 2008 22:46:13 +0000 Received: from implementation.famille.thibault.fr ([82.21.96.230]) by aamtaout04-winn.ispmail.ntl.com with ESMTP id <20080117224502.CVVP29112.aamtaout04-winn.ispmail.ntl.com@implementation.famille.thibault.fr> for ; Thu, 17 Jan 2008 22:45:02 +0000 Received: from samy by implementation.famille.thibault.fr with local (Exim 4.68) (envelope-from ) id 1JFdTm-0001sn-Ln for qemu-devel@nongnu.org; Thu, 17 Jan 2008 23:44:58 +0100 Date: Thu, 17 Jan 2008 22:44:58 +0000 From: Samuel Thibault Subject: Re: [Qemu-devel] Re: [PATCH] USB serial device Message-ID: <20080117224458.GD4300@implementation> References: <20080111002312.GE4304@implementation> <20080111110923.GB4223@implementation.uk.xensource.com> <20080113015556.GO4299@implementation> <20080113185930.GE4309@implementation> <20080117144706.GE4264@implementation.uk.xensource.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit andrzej zaborowski, le Thu 17 Jan 2008 23:25:04 +0100, a écrit : > Thanks, committed although I hoped for something that lets easily test > that the adapter works, e.g. so that after a usb_add serial:...:stdio > you can do cat /dev/ttyXXXN in the guest and see what's being typed on > qemu's stdin. I got the device detected without problems but Linux > didn't create any new serial ports. Oh? That's odd, I've no problem here, /dev/ttyUSB0 appears like a charm and cat & echo work fine. We should probably use another product ID by default, which would be more widely automatically recognized. Here is a patch. Samuel --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch Index: hw/usb-serial.c =================================================================== RCS file: /sources/qemu/qemu/hw/usb-serial.c,v retrieving revision 1.1 diff -u -p -r1.1 usb-serial.c --- hw/usb-serial.c 14 Jan 2008 03:41:02 -0000 1.1 +++ hw/usb-serial.c 17 Jan 2008 22:44:19 -0000 @@ -486,7 +486,7 @@ USBDevice *usb_serial_init(const char *f { USBSerialState *s; CharDriverState *cdrv; - unsigned short vendorid = 0x0403, productid = 0xFF00; + unsigned short vendorid = 0x0403, productid = 0x6001; while (*filename && *filename != ':') { const char *p; Index: qemu-doc.texi =================================================================== RCS file: /sources/qemu/qemu/qemu-doc.texi,v retrieving revision 1.181 diff -u -p -r1.181 qemu-doc.texi --- qemu-doc.texi 17 Jan 2008 22:22:45 -0000 1.181 +++ qemu-doc.texi 17 Jan 2008 22:44:20 -0000 @@ -1594,7 +1594,7 @@ Standard USB keyboard. Will override th Serial converter. This emulates an FTDI FT232BM chip connected to host character device @var{dev}. The available character devices are the same as for the @code{-serial} option. The @code{vendorid} and @code{productid} options can be -used to override the default 0403:FF00. For instance, +used to override the default 0403:6001. For instance, @example usb_add serial:productid=FA00:tcp:192.168.0.2:4444 @end example --IS0zKkzwUGydFO0o--