qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "M. Warner Losh" <imp@bsdimp.com>
To: qemu-devel@nongnu.org, paul@codesourcery.com
Cc: aliguori@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH] Allow default network type to be determined from an environmental variable
Date: Sat, 19 Jan 2008 15:47:07 -0700 (MST)	[thread overview]
Message-ID: <20080119.154707.-1648689246.imp@bsdimp.com> (raw)
In-Reply-To: <200801192110.11295.paul@codesourcery.com>

In message: <200801192110.11295.paul@codesourcery.com>
            Paul Brook <paul@codesourcery.com> writes:
: > In the absence of a global configuration file, a reasonably sane way to
: > support this configuration system wide is to use an environmental
: > variable.  QEMU already uses a number of global variables for
: > configuring audio options.
: 
: I'd really prefer we didn't do this, and preferably obsoleted/removed the 
: existing environment variables.  IMHO using environment variables is a really 
: bad idea and should be avoided wherever possible.
: 
: Environment variables are about the worst user interface I can think of. For a 
: start they're a global resource, which is limited on some systems.
: It's also extremely hard to determine what environment a user is running. This 
: makes reproducing user bugs somewhere between hard and impossible.

Other than quick, developer friendly hacks, the only time environment
variables make sense is to select globally something.  A hypothetical
QEMU_ROOT might be useful for selecting which tree of files qemu reads
from.  If you had multiple shells and wanted to run different
installations of qmeu in each, this would be useful.  But to have them
control more fine grain options is something to be avoided.  At least
that's how I've selected them in my programs in the past....

Please note: I'm not saying this is the right way to select between
multiple installed versions of qemu, just an example of when it makes
sense.

Warner

  parent reply	other threads:[~2008-01-19 22:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-13 21:20 [Qemu-devel] [PATCH] Allow default network type to be determined from an environmental variable Anthony Liguori
2008-01-19 21:10 ` Paul Brook
2008-01-19 22:40   ` Anthony Liguori
2008-01-19 22:47   ` M. Warner Losh [this message]
2008-02-12  0:17   ` Rob Landley
2008-02-12  1:42     ` Paul Brook
2008-02-12  2:19     ` andrzej zaborowski
2008-02-12  2:46       ` Paul Brook
2008-02-12  3:47         ` Anthony Liguori
2008-02-12 12:27           ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080119.154707.-1648689246.imp@bsdimp.com \
    --to=imp@bsdimp.com \
    --cc=aliguori@us.ibm.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).