[Qemu-devel] PS/2 mouse support for FC4 guest broken in QEMU 0.9.1

[Qemu-devel] PS/2 mouse support for FC4 guest broken in QEMU 0.9.1

[Even Rouault]

Hi,

I've tried QEMU 0.9.1 and PS/2 mouse support for FC4 guest seems to be broken. 
I was using previously a CVS version dating back to 2007/09/07 and it works 
fine with it.

It can be tested by simply running qemu on the FC4-i386-DVD.iso installation 
ISO DVD. Anaconda doesn't manage to find the mouse and fall back to text 
mode. On an already installed image, the mouse doesn't work in X or in text 
mode.

Best regards.

Re: [Qemu-devel] PS/2 mouse support for FC4 guest broken in QEMU 0.9.1

[Even Rouault]

After quite a lot of CVS bisection, I've identified revision 1.24 of 
hw/pckbd.c ("QEMU keyboard issue with Gujin-2.2") to be responsible for the 
regression with the PS/2 mouse for FC4 guests.

With r1.24, I can read in the log of the kernel boot sequence :
"PNP: PS/2 Controller [PNP0303:KBD,PNP0f13:MOU@ at 0x60,0x64 irq 1,12"
 Failed to disable AUX port, but continuing anyway... Is this a Sis?
 If AUX port is really absent please use the 'i8042.noaux' option.
 serio: i8042 KBD PORT at 0x60,0x64 irq 1"

With r1.23, I only get :
"PNP: PS/2 Controller [PNP0303:KBD,PNP0f13:MOU@ at 0x60,0x64 irq 1,12"
 serio: i8042 KBD PORT at 0x60,0x64 irq 1"

Le Sunday 20 January 2008 21:58:05 Even Rouault, vous avez écrit :
> Hi,
>
> I've tried QEMU 0.9.1 and PS/2 mouse support for FC4 guest seems to be
> broken. I was using previously a CVS version dating back to 2007/09/07 and
> it works fine with it.
>
> It can be tested by simply running qemu on the FC4-i386-DVD.iso
> installation ISO DVD. Anaconda doesn't manage to find the mouse and fall
> back to text mode. On an already installed image, the mouse doesn't work in
> X or in text mode.
>
> Best regards.

Re: [Qemu-devel] PS/2 mouse support for FC4 guest broken in QEMU 0.9.1

[Johannes Schindelin]

Hi,

On Sun, 20 Jan 2008, Even Rouault wrote:

> After quite a lot of CVS bisection, [...]

Not wanting to advertise git, but to help other people needing to bisect 
efficiently: here is a recipe how to do this with git.

1. get git (obviously)

2. $ git clone git://repo.or.cz/qemu.git/
   (it is a git mirror of git://git.kernel.dk/data/git/qemu.git, so if you 
    do not want to be nice to Jens' server, you can go there directly)

3. Find out what was the last good revision.  If you have an approximate 
   date take the first "commit" of the output of

	$ cd qemu/
	$ git log --until="2007/09/07"

   (It would show a line beginning with "commit " and followed by a 
    40-character hex sequence; copy that sequence)

4. Start the bisection

	$ git bisect start
	$ git bisect bad HEAD
	$ git bisect good 85f8a4e8bae4df3983a5f1efd62b7942417bb89b

   Obviously, you have to use the sequence you copied in 3.

5. Compile, test, and call

	$ git bisect good

   or

	$ git bisect bad

   after the test, depending if the tested revision is good or -- you 
   guessed it -- bad.

6. Repeat 5. until git tells you which is probably the bad commit.  Then 
   scrap this clone, or go back to the CVS HEAD with

	$ git bisect reset

You are literally guaranteed to test the minimal amount of revisions with 
this procedure.

Hth,
Dscho

Re: [Qemu-devel] PS/2 mouse support for FC4 guest broken in QEMU 0.9.1

[Even Rouault]

Thanks for the tutorial on how to use git bisection ;-)
In fact, whatever version control system you use, I think you spend most of 
time recompiling and testing stuff...

Anyway, on the core problem I'm pointing out, does someone have any clue on 
what should be done ? Should the revision 1.24 of 
hw/pckbd.c ("QEMU keyboard issue with Gujin-2.2") be reverted ? Is there a way 
to get FC4 to work again, and "Gujin" at the same time ? Is the patch of 
revision 1.24 the right fix for Gujin and another additionnal fix is required 
for the FC4 issue (presumably related to Linux kernel version 2.6.11) or 
should it be reverted and a better fix found for Gujin ?

I tried to follow the discussion about that topic 
(http://www.mail-archive.com/qemu-devel%40nongnu.org/msg12455.html) but I'm 
afraid I'm lost in the details.

Best regards

Le Monday 21 January 2008 00:54:27, vous avez écrit :
> Hi,
>
> On Sun, 20 Jan 2008, Even Rouault wrote:
> > After quite a lot of CVS bisection, [...]
>
> Not wanting to advertise git, but to help other people needing to bisect
> efficiently: here is a recipe how to do this with git.
>
> 1. get git (obviously)
>
> 2. $ git clone git://repo.or.cz/qemu.git/
>    (it is a git mirror of git://git.kernel.dk/data/git/qemu.git, so if you
>     do not want to be nice to Jens' server, you can go there directly)
>
> 3. Find out what was the last good revision.  If you have an approximate
>    date take the first "commit" of the output of
>
> 	$ cd qemu/
> 	$ git log --until="2007/09/07"
>
>    (It would show a line beginning with "commit " and followed by a
>     40-character hex sequence; copy that sequence)
>
> 4. Start the bisection
>
> 	$ git bisect start
> 	$ git bisect bad HEAD
> 	$ git bisect good 85f8a4e8bae4df3983a5f1efd62b7942417bb89b
>
>    Obviously, you have to use the sequence you copied in 3.
>
> 5. Compile, test, and call
>
> 	$ git bisect good
>
>    or
>
> 	$ git bisect bad
>
>    after the test, depending if the tested revision is good or -- you
>    guessed it -- bad.
>
> 6. Repeat 5. until git tells you which is probably the bad commit.  Then
>    scrap this clone, or go back to the CVS HEAD with
>
> 	$ git bisect reset
>
> You are literally guaranteed to test the minimal amount of revisions with
> this procedure.
>
> Hth,
> Dscho

Re: [Qemu-devel] PS/2 mouse support for FC4 guest broken in QEMU 0.9.1

[andrzej zaborowski]

On 21/01/2008, Even Rouault <even.rouault@mines-paris.org> wrote:
> Thanks for the tutorial on how to use git bisection ;-)
> In fact, whatever version control system you use, I think you spend most of
> time recompiling and testing stuff...
>
> Anyway, on the core problem I'm pointing out, does someone have any clue on
> what should be done ? Should the revision 1.24 of
> hw/pckbd.c ("QEMU keyboard issue with Gujin-2.2") be reverted ? Is there a way
> to get FC4 to work again, and "Gujin" at the same time ? Is the patch of
> revision 1.24 the right fix for Gujin and another additionnal fix is required
> for the FC4 issue (presumably related to Linux kernel version 2.6.11) or
> should it be reverted and a better fix found for Gujin ?

I have no clue about ps2 but seeing as redirecting the command from
kbd to mouse (0 -> 1 in the kbd_queue call) fixes the keyboard issue
for Gujin, but breaks mouse, the obvious conclusion is that the
command should not be done for either kbd or mouse.  Can you try with
line 214 (previously line 207) simply removed?  If you can test also
how that affects Gujin that would be even better.

Cheers

Re: [Qemu-devel] PS/2 mouse support for FC4 guest broken in QEMU 0.9.1

[Even Rouault]

Le Sunday 03 February 2008 04:15:52 andrzej zaborowski, vous avez écrit :

> I have no clue about ps2 but seeing as redirecting the command from
> kbd to mouse (0 -> 1 in the kbd_queue call) fixes the keyboard issue
> for Gujin, but breaks mouse, the obvious conclusion is that the
> command should not be done for either kbd or mouse.  Can you try with
> line 214 (previously line 207) simply removed?  If you can test also
> how that affects Gujin that would be even better.
>
> Cheers

I've tried as you suggested to remove line 214 ( "kbd_queue(s, s->mode, 1)" ), 
and it breaks both keyboard and mouse support for the FC4 install DVD or my 
FC4 disk image.
When booting the FC4 disk image, I can read "i8042.c : Can't read CTR while 
initializing i8042." in the kernel boot log.

As far as Gujin is concerned, it would be great if people familiar with it 
could try. I'm looking for an available disk image with Gujin as the boot 
loader but no success for the moment. I guess I'll have to figure how to 
install and use it.

Best regards.