From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] CPPFLAGS+= in Makefile.target
Date: Fri, 25 Jan 2008 16:03:10 +0000 [thread overview]
Message-ID: <200801251603.12341.paul@codesourcery.com> (raw)
In-Reply-To: <18330.565.643731.225337@mariner.uk.xensource.com>
> Providing a definition in config-host.mak involves duplicating the
> value, which can't be right.
Huh? No it doesn't. config-host.mak contains
CPPFLAGS=
then Makefile.target contains
CPPFLAGS+=whatever
> If there's no other way to do it then
> there should be a reference to USER_CPPFLAGS or some such but frankly
> that's a pain and overkill.
Why don't you just put your custom flags in CFLAGS, not CPPFLAGS?
The former is deliberately left for the user to override.
Paul
next prev parent reply other threads:[~2008-01-25 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 14:18 [Qemu-devel] [PATCH] CPPFLAGS+= in Makefile.target Ian Jackson
2008-01-25 14:39 ` Paul Brook
2008-01-25 14:44 ` Ian Jackson
2008-01-25 14:48 ` Ian Jackson
2008-01-25 15:36 ` Paul Brook
2008-01-25 15:37 ` Ian Jackson
2008-01-25 15:53 ` Paul Brook
2008-01-25 16:03 ` Ian Jackson
2008-01-25 16:03 ` Paul Brook [this message]
2008-01-25 16:12 ` Ian Jackson
2008-01-25 16:22 ` Paul Brook
2008-01-25 16:29 ` Ian Jackson
2008-01-28 9:09 ` Ronan Keryell
2008-01-28 11:35 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801251603.12341.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).