From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJSGX-0004ob-Eg for qemu-devel@nongnu.org; Mon, 28 Jan 2008 06:35:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJSGV-0004oP-RF for qemu-devel@nongnu.org; Mon, 28 Jan 2008 06:35:04 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJSGV-0004oM-EO for qemu-devel@nongnu.org; Mon, 28 Jan 2008 06:35:03 -0500 Received: from relay01.mx.bawue.net ([193.7.176.67]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JJSGU-0003zz-CY for qemu-devel@nongnu.org; Mon, 28 Jan 2008 06:35:03 -0500 Date: Mon, 28 Jan 2008 11:35:00 +0000 From: Thiemo Seufer Subject: Re: [Qemu-devel] [PATCH] CPPFLAGS+= in Makefile.target Message-ID: <20080128113500.GA23119@networkno.de> References: <18329.61367.473953.391435@mariner.uk.xensource.com> <200801251439.58215.paul@codesourcery.com> <87ir1egvtl.fsf@an-dro.enstb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ir1egvtl.fsf@an-dro.enstb.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ronan Keryell Cc: qemu-devel@nongnu.org Ronan Keryell wrote: > >>>>> On Fri, 25 Jan 2008 14:39:57 +0000, Paul Brook said: > > >> Saying CPPFLAGS+= is much more convenient if for any reason the > >> external build environment would like to pass unusual CPPFLAGS. > > Paul> No. This doesn't do what you thing it does. The most common way > Paul> of overriding these variables is to pass them on the > Paul> commandline, i.e. "make CPPFLAGS=-blah". This overrides all > Paul> assignments to that variable including +=. > > By the way, it is possible to improve the GNU make weirdness :-) by > playing with stuff like: > > override CFLAGS += -g > > Cf section 6.7 of the documentation. IIRC the documentation warns against careless use of overrides. > Hmmm... GNU make evolves more rapidly than my brain... :-) It's only a decade old or so. :-) Thiemo