[Qemu-devel] [PATCH] Fix lock_iovec

[Qemu-devel] [PATCH] Fix lock_iovec

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Do not stop iovec conversion on iov_base == NULL if iov_len is 0

---
 linux-user/syscall.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index d099e97..5dc6594 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1028,7 +1028,7 @@ static abi_long lock_iovec(int type, struct iovec *vec, abi_ulong target_addr,
         base = tswapl(target_vec[i].iov_base);
         vec[i].iov_len = tswapl(target_vec[i].iov_len);
         vec[i].iov_base = lock_user(type, base, vec[i].iov_len, copy);
-       if (!vec[i].iov_base) 
+       if (!vec[i].iov_base && vec[i].iov_len)
             goto fail;
     }
     unlock_user (target_vec, target_addr, 0);
-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + Velesys Ltd, http://www.velesys.com/
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Qemu-devel] [PATCH] Fix lock_iovec

[Mulyadi Santosa]

Hi...

On Jan 29, 2008 11:59 PM, Kirill A. Shutemov <k.shutemov@gmail.com> wrote:
> Do not stop iovec conversion on iov_base == NULL if iov_len is 0
"is 0" or "is not 0"?

regards,

Mulyadi.

Re: [Qemu-devel] [PATCH] Fix lock_iovec

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On [Wed, 30.01.2008 19:56], Mulyadi Santosa wrote:
> Hi...
> 
> On Jan 29, 2008 11:59 PM, Kirill A. Shutemov <k.shutemov@gmail.com> wrote:
> > Do not stop iovec conversion on iov_base == NULL if iov_len is 0
> "is 0" or "is not 0"?

For now, iovec conversion stops on iov_base == NULL, but NULL in iov_base
is correct if iov_len is 0.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + Velesys Ltd, http://www.velesys.com/
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]