From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JKjXt-0007GB-AY
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:14:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JKjXr-0007Fh-JV
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:14:16 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JKjXr-0007Fd-9J
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:14:15 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JKjXq-00026N-Rp
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:14:15 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Fri, 1 Feb 2008 00:14:05 +0000
References: <1201818980-27534-1-git-send-email-aliguori@us.ibm.com>
	<1201818980-27534-5-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1201818980-27534-5-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802010014.07960.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 4/6] Tell BIOS about the number of CPUs
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org

> -    cmos_init(ram_size, above_4g_mem_size, boot_device, hd);
> +    cmos_init(ram_size, above_4g_mem_size, boot_device, hd, smp_cpus);

smp_cpus is a global variable. Why bother passing it around?

Are the CMOS contents documented anywhere?

Paul